Feature/experiment folders - #28
Merged
Merged
Conversation
KFilippopolitis
marked this pull request as ready for review
September 11, 2026 07:30
KFilippopolitis
force-pushed
the
feature/experiment-folders
branch
from
September 11, 2026 07:39
9d6e18c to
596d603
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| # Build the spring boot maven project | ||
| ####################################################### | ||
| FROM maven:3.9.11-amazoncorretto-21 AS mvn-build-env | ||
| FROM maven:3.9.16-amazoncorretto-21 AS mvn-build-env |
| # Setup the running container | ||
| ####################################################### | ||
| FROM amazoncorretto:21-alpine3.21 | ||
| FROM amazoncorretto:21-alpine3.24 |
| # openssl 3.5.7-r0, which carries CVE-2026-14456, CVE-2026-63073 and | ||
| # CVE-2026-75803 (CVSS >= 8.0, blocks the container SCA gate). Alpine 3.24 | ||
| # fixes them in openssl 3.5.8-r0. | ||
| RUN apk add --no-cache --upgrade libcrypto3 libssl3 curl |
ThanKarab
self-requested a review
September 15, 2026 06:57
ThanKarab
reviewed
Sep 15, 2026
ThanKarab
left a comment
ThanKarab
left a comment
Contributor
There was a problem hiding this comment.
What is the experiment vs analysis terminology?
| steps: | ||
| - name: Check out repository | ||
| uses: actions/checkout@df4cb1c069e1874edd31b4311f1884172cec0e10 # v6.0.3 | ||
| uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1 |
ThanKarab
self-requested a review
September 15, 2026 07:02
ThanKarab
approved these changes
Sep 15, 2026
Drop unused dataset mapping helpers, Lombok/Gson/Spring Data REST annotations, and blank-line noise. Collapse the Logger level switch into one formatter and reuse a static ObjectMapper in JsonConverters.
…cations endpoints - Delete AlgorithmService/AlgorithmsAPI, the disabled-algorithms resource, and the now-unused resource/stream helpers. - Add AnalysisAPI/AnalysisService for execution and SpecificationsAPI/SpecificationsService for Exaflow inputdata, preprocessing and algorithm specifications. - Route persisted and transient experiments through AnalysisRequestDTO, read stored analysis JSON directly, and drop the legacy algorithm payload adapter and custom deserializer. - Stamp experiments with the configured MIP version instead of the request body. - Replace the reflection-based non-editable-field check with explicit null checks. - Cover the new request/response shapes with focused tests.
Folders hold experiment ids, sets are ordered names, and a single member row per (folder, experiment) makes sets a strict partition. Add the three JPA entities, the repository (including the pessimistic folder-row lock), and Flyway V2; wire hbp.mip.folder into PersistenceConfiguration.
Expose /experiment-folders for folders, sets and memberships, scoped to the active user with 404 for another owner's ids and 409 for duplicate names. Reuse one experiment access check from ExperimentService, and map conflicts through ControllerExceptionHandler.
Pin naming and ownership rules, idempotent membership, strict-partition set moves, ordering, the lost-race 409, the wire DTO shapes, and every documented status code.
DT4H Keycloak returns UserInfo as application/jwt, which Spring's default OidcUserService rejects. Build the OidcUser from the ID token claims instead, and carry an OidcUserAuthority so the existing GrantedAuthoritiesMapper can still map claim authorities for session-authenticated users.
Move Spring Boot to 4.1.1 and refresh Hibernate, Flyway, springdoc, PostgreSQL JDBC, Lombok, SnakeYAML, Jackson and Tomcat to their newest stable patches. The Jackson suppressions are obsolete, so remove them instead of leaving stale ignore entries. Replace the unused Data REST starter with the Web MVC starter.
Refresh the SHA-pinned scanner releases and GitHub Actions so the SCA, SAST, container and publish pipelines stop drifting silently.
Move database, Keycloak, Exaflow, frontend and MIP version settings to
${ENV:default} placeholders in application.yml, drop the dockerize template and
run the jar directly. Refresh the build and runtime base images and upgrade
OpenSSL in the runtime image to clear the container SCA gate.
Describe the Specifications/Analysis modules, the folder package and its API contract, the environment-driven configuration model, and record the dependency/CI baselines.
KFilippopolitis
force-pushed
the
feature/experiment-folders
branch
from
September 15, 2026 11:42
d99cde4 to
816954c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.