Skip to content

examples(oglo_tactile): package under isaacteleop_examples - #1042

Open
jiwenc-nv wants to merge 1 commit into
jiwenc-nv/examples-noitomfrom
jiwenc-nv/examples-oglo-tactile
Open

examples(oglo_tactile): package under isaacteleop_examples#1042
jiwenc-nv wants to merge 1 commit into
jiwenc-nv/examples-noitomfrom
jiwenc-nv/examples-oglo-tactile

Conversation

@jiwenc-nv

@jiwenc-nv jiwenc-nv commented Aug 28, 2026

Copy link
Copy Markdown
Collaborator

Description

Part of #985. Stacked on #1041.

oglo_teleop_record.py imported oglo_heatmap as a top-level module, which resolved only because the invoked script's own directory landed on sys.path. This moves the tree to the layout in examples/README.md.

The example gains its first pyproject.toml, so the README's loose pip install pillow numpy / pip install cupy-cuda12x become an install of the example and its gpu extra. cupy stays optional — without it the renderer still writes PNGs and only the in-headset overlay is lost.

One path fix the move forces. _default_plugin_bin() walked up parents[2] to the repo root; three levels deeper that lands on the example's python/ directory. It is now parents[5], with a note that it only resolves from a source checkout — an installed copy lands in site-packages, where the existing PATH fallback takes over.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Testing

x86_64 / Ubuntu, Python 3.12. Wheel ships both modules under isaacteleop_examples/oglo_tactile/ with no namespace __init__.py. Editable-installed into a clean venv, both import with the CWD outside the repo; import oglo_heatmap fails. parents[5] verified to land on the repo root. pre-commit clean.

Not covered: nothing here has an OGLO glove. The dependency list is inferred from imports and this example never had one before, so a missing runtime dep would only show on the machine with the gloves attached.

Checklist

  • I have read and understood the contribution guidelines
  • I have run the linter and formatter with SKIP=check-copyright-year pre-commit run --all-files
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix/feature works (or explained why not)
  • I have signed off all my commits (git commit -s) per the DCO

No tests: this is a move, and no CI has the hardware.

@coderabbitai

coderabbitai Bot commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 04405b5d-382e-4111-8400-d49ba9b73b4e

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@jiwenc-nv
jiwenc-nv force-pushed the jiwenc-nv/examples-oglo-tactile branch from 52c2c49 to 49cfeb2 Compare August 28, 2026 05:00
@jiwenc-nv
jiwenc-nv changed the base branch from jiwenc-nv/examples-deviceio-live-view to jiwenc-nv/examples-noitom August 28, 2026 05:01
@jiwenc-nv
jiwenc-nv requested a review from ivany-nv August 28, 2026 05:11
@jiwenc-nv
jiwenc-nv force-pushed the jiwenc-nv/examples-oglo-tactile branch from 49cfeb2 to 0289283 Compare August 28, 2026 05:23
@jiwenc-nv
jiwenc-nv force-pushed the jiwenc-nv/examples-oglo-tactile branch from 0289283 to 9c39d3a Compare August 28, 2026 05:32
@jiwenc-nv
jiwenc-nv force-pushed the jiwenc-nv/examples-oglo-tactile branch from 9c39d3a to 50a02a5 Compare August 28, 2026 05:44
@jiwenc-nv
jiwenc-nv force-pushed the jiwenc-nv/examples-oglo-tactile branch from 50a02a5 to 3535522 Compare August 28, 2026 05:48

@ivany-nv ivany-nv left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read the diff line by line. Two changes beyond the move: the oglo_heatmap import becoming relative, and here.parents[2] becoming here.parents[5]. Checked the arithmetic — from python/isaacteleop_examples/oglo_tactile/, the repo root is five parents up, so that is right, and the comment about an installed copy falling through to the PATH lookup matches the code.

Not installed by install_python_example() and I have no OGLO hardware here, so nothing to run.

@jiwenc-nv
jiwenc-nv force-pushed the jiwenc-nv/examples-oglo-tactile branch from 3535522 to b6c1cb7 Compare August 28, 2026 14:46
@jiwenc-nv
jiwenc-nv force-pushed the jiwenc-nv/examples-oglo-tactile branch from b6c1cb7 to 78ca635 Compare August 28, 2026 16:11
@jiwenc-nv
jiwenc-nv force-pushed the jiwenc-nv/examples-oglo-tactile branch from 78ca635 to c6be03e Compare August 28, 2026 23:49
@jiwenc-nv
jiwenc-nv force-pushed the jiwenc-nv/examples-oglo-tactile branch from c6be03e to b6f7a5e Compare August 29, 2026 00:21
@jiwenc-nv
jiwenc-nv force-pushed the jiwenc-nv/examples-oglo-tactile branch from b6f7a5e to 1091d9c Compare August 29, 2026 01:19
@jiwenc-nv
jiwenc-nv force-pushed the jiwenc-nv/examples-oglo-tactile branch from 1091d9c to 391f883 Compare August 30, 2026 16:23
@jiwenc-nv
jiwenc-nv force-pushed the jiwenc-nv/examples-oglo-tactile branch from 391f883 to e3693eb Compare August 31, 2026 15:09
@jiwenc-nv
jiwenc-nv force-pushed the jiwenc-nv/examples-oglo-tactile branch from e3693eb to f1bbbd1 Compare September 2, 2026 16:13
@jiwenc-nv
jiwenc-nv force-pushed the jiwenc-nv/examples-oglo-tactile branch from f1bbbd1 to b9b7e19 Compare September 3, 2026 15:54
oglo_teleop_record.py imported oglo_heatmap as a top-level module, which
resolved only because the invoked script's own directory landed on sys.path.
Move the tree to the layout in examples/README.md.

The example gains its first pyproject.toml, so the README's `pip install pillow
numpy` / `pip install cupy-cuda12x` become an install of the example and its
`gpu` extra. cupy stays optional: without it the renderer still writes PNGs and
only the in-headset overlay is lost.

The plugin-binary probe walked up parents[2] to the repo root, which after the
move points at the example's python/ directory. Now parents[5], with a note
that it only resolves in a source checkout -- an installed copy lands in
site-packages, where the existing PATH fallback takes over.

Part of #985.

Signed-off-by: Jiwen Cai <jiwenc@nvidia.com>
@jiwenc-nv
jiwenc-nv force-pushed the jiwenc-nv/examples-oglo-tactile branch from b9b7e19 to 3a0d911 Compare September 3, 2026 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants