examples(cloudxr_mujoco_teleop): package under isaacteleop_examples - #1045
examples(cloudxr_mujoco_teleop): package under isaacteleop_examples#1045jiwenc-nv wants to merge 1 commit into
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
b52698c to
d049e6e
Compare
d049e6e to
f3dc39f
Compare
f3dc39f to
bb79a92
Compare
bb79a92 to
a8bf13c
Compare
a8bf13c to
54d93c4
Compare
ivany-nv
left a comment
There was a problem hiding this comment.
Read the diff line by line: every Python file is a 100% rename, so the only new content is the pyproject.toml (only-include + sources, no __init__.py on the namespace) and the README path updates.
Not installed by install_python_example(), so there is no install tree to check.
54d93c4 to
41605e3
Compare
41605e3 to
b6e62e0
Compare
b6e62e0 to
5c0a140
Compare
5c0a140 to
89eed97
Compare
89eed97 to
2744b66
Compare
2744b66 to
02eb44a
Compare
02eb44a to
b7e0b88
Compare
b7e0b88 to
eb81849
Compare
eb81849 to
a5e7711
Compare
No flat sibling imports -- the two scripts are independent -- but the tree ran as `uv run <script>.py` from its own directory, so it needed the same conversion as the rest for one install command to work everywhere. Move it to the layout in examples/README.md. vive_assets/ moves inside the package: both scripts resolve ASSETS_DIR from __file__, so the meshes have to travel with the modules, and the wheel now carries them. The REUSE override for examples/cloudxr_mujoco_teleop/** still covers the nested paths, so the HTC copyright is unaffected. Part of #985. Signed-off-by: Jiwen Cai <jiwenc@nvidia.com>
a5e7711 to
e9a6e8b
Compare
Description
Part of #985. Stacked on #1044.
No flat sibling imports — the two scripts are independent — but the tree ran as
uv run <script>.pyfrom its own directory, so it needed the same conversion as the rest for one install command to work across every example.vive_assets/moves inside the package: both scripts resolveASSETS_DIRfrom__file__, so the meshes have to travel with the modules or the move would silently break them. The wheel now carries them (6 asset files), matching howmujoco_xrships its own assets.The
REUSE.tomloverride forexamples/cloudxr_mujoco_teleop/**still covers the nested paths, so the HTC copyright is unaffected.Type of change
Testing
x86_64/ Ubuntu, Python 3.12. Wheel ships 3 modules and all 6vive_assetsfiles underisaacteleop_examples/cloudxr_mujoco_teleop/, with no namespace__init__.py.pre-commitclean.Not covered: both need a headset and a CloudXR runtime. The asset move is the part worth eyeing — if the meshes fail to load,
ASSETS_DIRis the reason.Checklist
SKIP=check-copyright-year pre-commit run --all-filesgit commit -s) per the DCONo tests: this is a move with no import changes.