Skip to content

examples(cloudxr_mujoco_teleop): package under isaacteleop_examples - #1045

Open
jiwenc-nv wants to merge 1 commit into
jiwenc-nv/examples-haptic-feedbackfrom
jiwenc-nv/examples-cloudxr-mujoco-teleop
Open

examples(cloudxr_mujoco_teleop): package under isaacteleop_examples#1045
jiwenc-nv wants to merge 1 commit into
jiwenc-nv/examples-haptic-feedbackfrom
jiwenc-nv/examples-cloudxr-mujoco-teleop

Conversation

@jiwenc-nv

@jiwenc-nv jiwenc-nv commented Aug 28, 2026

Copy link
Copy Markdown
Collaborator

Description

Part of #985. Stacked on #1044.

No flat sibling imports — the two scripts are independent — but the tree ran as uv run <script>.py from its own directory, so it needed the same conversion as the rest for one install command to work across every example.

uv pip install -e ./examples/cloudxr_mujoco_teleop
python -m isaacteleop_examples.cloudxr_mujoco_teleop.visualize_poses_mujoco_example

vive_assets/ moves inside the package: both scripts resolve ASSETS_DIR from __file__, so the meshes have to travel with the modules or the move would silently break them. The wheel now carries them (6 asset files), matching how mujoco_xr ships its own assets.

The REUSE.toml override for examples/cloudxr_mujoco_teleop/** still covers the nested paths, so the HTC copyright is unaffected.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Testing

x86_64 / Ubuntu, Python 3.12. Wheel ships 3 modules and all 6 vive_assets files under isaacteleop_examples/cloudxr_mujoco_teleop/, with no namespace __init__.py. pre-commit clean.

Not covered: both need a headset and a CloudXR runtime. The asset move is the part worth eyeing — if the meshes fail to load, ASSETS_DIR is the reason.

Checklist

  • I have read and understood the contribution guidelines
  • I have run the linter and formatter with SKIP=check-copyright-year pre-commit run --all-files
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix/feature works (or explained why not)
  • I have signed off all my commits (git commit -s) per the DCO

No tests: this is a move with no import changes.

@coderabbitai

coderabbitai Bot commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: e75595cb-d6f8-4b70-b20e-463ae7eac31f

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@jiwenc-nv
jiwenc-nv force-pushed the jiwenc-nv/examples-cloudxr-mujoco-teleop branch from b52698c to d049e6e Compare August 28, 2026 05:01
@jiwenc-nv
jiwenc-nv changed the base branch from jiwenc-nv/examples-deviceio-live-view to jiwenc-nv/examples-haptic-feedback August 28, 2026 05:02
@jiwenc-nv
jiwenc-nv requested a review from ivany-nv August 28, 2026 05:11
@jiwenc-nv
jiwenc-nv force-pushed the jiwenc-nv/examples-cloudxr-mujoco-teleop branch from d049e6e to f3dc39f Compare August 28, 2026 05:23
@jiwenc-nv
jiwenc-nv force-pushed the jiwenc-nv/examples-cloudxr-mujoco-teleop branch from f3dc39f to bb79a92 Compare August 28, 2026 05:32
@jiwenc-nv
jiwenc-nv force-pushed the jiwenc-nv/examples-cloudxr-mujoco-teleop branch from bb79a92 to a8bf13c Compare August 28, 2026 05:44
@jiwenc-nv
jiwenc-nv force-pushed the jiwenc-nv/examples-cloudxr-mujoco-teleop branch from a8bf13c to 54d93c4 Compare August 28, 2026 05:49

@ivany-nv ivany-nv left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read the diff line by line: every Python file is a 100% rename, so the only new content is the pyproject.toml (only-include + sources, no __init__.py on the namespace) and the README path updates.

Not installed by install_python_example(), so there is no install tree to check.

@jiwenc-nv
jiwenc-nv force-pushed the jiwenc-nv/examples-cloudxr-mujoco-teleop branch from 54d93c4 to 41605e3 Compare August 28, 2026 14:46
@jiwenc-nv
jiwenc-nv force-pushed the jiwenc-nv/examples-cloudxr-mujoco-teleop branch from 41605e3 to b6e62e0 Compare August 28, 2026 16:11
@jiwenc-nv
jiwenc-nv force-pushed the jiwenc-nv/examples-cloudxr-mujoco-teleop branch from b6e62e0 to 5c0a140 Compare August 28, 2026 23:49
@jiwenc-nv
jiwenc-nv force-pushed the jiwenc-nv/examples-cloudxr-mujoco-teleop branch from 5c0a140 to 89eed97 Compare August 29, 2026 00:21
@jiwenc-nv
jiwenc-nv force-pushed the jiwenc-nv/examples-cloudxr-mujoco-teleop branch from 89eed97 to 2744b66 Compare August 29, 2026 01:19
@jiwenc-nv
jiwenc-nv force-pushed the jiwenc-nv/examples-cloudxr-mujoco-teleop branch from 2744b66 to 02eb44a Compare August 30, 2026 16:23
@jiwenc-nv
jiwenc-nv force-pushed the jiwenc-nv/examples-cloudxr-mujoco-teleop branch from 02eb44a to b7e0b88 Compare August 31, 2026 15:09
@jiwenc-nv
jiwenc-nv force-pushed the jiwenc-nv/examples-cloudxr-mujoco-teleop branch from b7e0b88 to eb81849 Compare September 2, 2026 16:13
@jiwenc-nv
jiwenc-nv force-pushed the jiwenc-nv/examples-cloudxr-mujoco-teleop branch from eb81849 to a5e7711 Compare September 3, 2026 15:54
No flat sibling imports -- the two scripts are independent -- but the tree ran
as `uv run <script>.py` from its own directory, so it needed the same
conversion as the rest for one install command to work everywhere. Move it to
the layout in examples/README.md.

vive_assets/ moves inside the package: both scripts resolve ASSETS_DIR from
__file__, so the meshes have to travel with the modules, and the wheel now
carries them. The REUSE override for examples/cloudxr_mujoco_teleop/** still
covers the nested paths, so the HTC copyright is unaffected.

Part of #985.

Signed-off-by: Jiwen Cai <jiwenc@nvidia.com>
@jiwenc-nv
jiwenc-nv force-pushed the jiwenc-nv/examples-cloudxr-mujoco-teleop branch from a5e7711 to e9a6e8b Compare September 3, 2026 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants