sensing: add the SENSING SG8A SIPL camera plugin - #998
Draft
jiwenc-nv wants to merge 1 commit into
Draft
Conversation
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueComment |
| if self._sock is not None: | ||
| try: | ||
| self._sock.close() | ||
| except OSError: |
Collaborator
Author
|
/preview-docs |
Contributor
|
✅ Preview deployed: https://NVIDIA.github.io/IsaacTeleop/preview/pr-998/ |
jiwenc-nv
force-pushed
the
jiwenc/camera-cuda
branch
from
September 4, 2026 03:47
549bf0b to
e06ba90
Compare
jiwenc-nv
force-pushed
the
jiwenc/camera-cuda
branch
from
September 4, 2026 04:13
e06ba90 to
2e991b7
Compare
This was referenced Sep 4, 2026
jiwenc-nv
force-pushed
the
jiwenc/camera-cuda
branch
from
September 4, 2026 04:18
2e991b7 to
8f52a5d
Compare
jiwenc-nv
force-pushed
the
jiwenc/camera-cuda
branch
from
September 4, 2026 04:33
8f52a5d to
cbac119
Compare
jiwenc-nv
force-pushed
the
jiwenc/camera-cuda
branch
from
September 4, 2026 04:42
cbac119 to
ab958b8
Compare
jiwenc-nv
force-pushed
the
jiwenc/camera-cuda
branch
2 times, most recently
from
September 4, 2026 04:50
d4b596c to
65fbfe8
Compare
jiwenc-nv
force-pushed
the
jiwenc/camera-cuda
branch
from
September 4, 2026 04:54
65fbfe8 to
c861ef5
Compare
jiwenc-nv
force-pushed
the
jiwenc/camera-cuda
branch
from
September 4, 2026 05:00
c861ef5 to
eb32d1d
Compare
jiwenc-nv
force-pushed
the
jiwenc/camera-cuda
branch
from
September 4, 2026 15:32
eb32d1d to
e7bdc28
Compare
jiwenc-nv
force-pushed
the
jiwenc/camera-cuda
branch
2 times, most recently
from
September 4, 2026 21:39
3c5ccdd to
0dce783
Compare
jiwenc-nv
force-pushed
the
jiwenc/camera-cuda
branch
from
September 4, 2026 21:42
0dce783 to
abbe65e
Compare
jiwenc-nv
force-pushed
the
jiwenc/camera-cuda
branch
from
September 4, 2026 21:59
abbe65e to
296c861
Compare
jiwenc-nv
force-pushed
the
jiwenc/camera-cuda
branch
from
September 4, 2026 22:15
296c861 to
42a0809
Compare
jiwenc-nv
force-pushed
the
jiwenc/camera-cuda
branch
from
September 4, 2026 22:25
42a0809 to
3b900ea
Compare
jiwenc-nv
force-pushed
the
jiwenc/camera-cuda
branch
from
September 4, 2026 22:38
3b900ea to
a13a29f
Compare
jiwenc-nv
force-pushed
the
jiwenc/camera-cuda
branch
from
September 4, 2026 22:52
a13a29f to
a84459e
Compare
New C++ plugin camera_plugin_sensing for the SENSING SG8A-AGON-G2Y-A1 GMSL carrier on a Jetson AGX Orin (JetPack 7.2.1 / L4T R39.2.1). It captures two Astra SHW5G at 2560x1984@60 through SIPL and either encodes H.264 on the V4L2 M2M engine or publishes frames over the CUDA IPC transport. The carrier ships no kernel sensor drivers and no /dev/video*: SIPL owns the sensors from userspace, so there is no daemon, no per-boot module load and no V4L2 controls. Capture runs as the ordinary container user, needing only the video, i2c and gpio groups. Four SIPL requirements look arbitrary and are not -- call ordering around Init(), mandatory ICP buffers, NeedCpuAccess on the producer attribute list, and REC709_ER on ISP0. Each is commented where it is enforced; getting any of them wrong fails silently or with a status code that names nothing. sensing.rst and the plugin README carry the rig details. shw5g.json is a verbatim copy of the vendor platform config; configs/README.md records its provenance and the rule against editing it in place. Auto-exposure saturates with sensor gain pinned at 1.0. That reproduces in NVIDIA's own nvsipl_camera, so it is upstream; tracked in #1076. Signed-off-by: Jiwen Cai <jiwenc@nvidia.com>
jiwenc-nv
force-pushed
the
jiwenc/camera-cuda
branch
from
September 10, 2026 17:59
a84459e to
df92062
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Stack 3/3 — depends on #1078 (which depends on #1077). Review that order; this PR's diff is only the plugin.
New C++ plugin
camera_plugin_sensingfor the SENSING SG8A-AGON-G2Y-A1 GMSL carrier on a Jetson AGX Orin (JetPack 7.2.1 / L4T R39.2.1). It captures two Astra SHW5G at 2560×1984 @ 60 through SIPL and either encodes H.264 on the V4L2 M2M engine or publishes frames over the CUDA IPC transport from #1078.The carrier ships no kernel sensor drivers and no
/dev/video*— SIPL owns the sensors from userspace — so there is no daemon, no per-boot module load and no V4L2 controls.Four SIPL requirements look arbitrary and are not: call ordering around
Init(), mandatory ICP buffers,NeedCpuAccesson the producer attribute list, andREC709_ERon ISP0. Each is commented where it is enforced; getting any of them wrong fails silently or with a status code that names nothing.--add-stream sensor=Nis the SIPL pipeline index (0 and 1), not the GMSL link index, CSI virtual channel, or JSONsensorInfo.id— all of which are 2 and 3 on this rig.Auto-exposure saturates with sensor gain pinned at 1.0. That reproduces in NVIDIA's own
nvsipl_camera, so it is upstream; tracked in #1076.Type of change
Testing
AGX Orin, JetPack 7.2.1 / L4T R39.2.1, SG8A carrier with two Astra SHW5G:
video/i2c/gpio.--list-sensorsandctest -R sipl_queryassert pipeline indices and geometry with no camera attached.SKIP=check-copyright-year pre-commit run --all-filespasses.H.264 recording and the MCAP metadata path are not yet verified end to end on this rig.
Checklist
SKIP=check-copyright-year pre-commit run --all-filesgit commit -s) per the DCO