Skip to content

Align review test randomness guidance with repository policy - #1079

Merged
rusty1s merged 1 commit into
mainfrom
fix/review-test-randomness-guidance
Oct 9, 2026
Merged

rusty1s merged 1 commit into
mainfrom
fix/review-test-randomness-guidance

Conversation

@aw471

@aw471 aw471 commented Oct 9, 2026

Copy link
Copy Markdown
Collaborator

The review and test-generation instructions required seeds for all randomness, conflicting with AGENTS.md. Require seed or generator control only when the tested behavior needs it.

Signed-off-by: Ard <88337265+aw471@users.noreply.github.com>
@copy-pr-bot

copy-pr-bot Bot commented Oct 9, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@rusty1s rusty1s left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. This was annoying :D

@rusty1s
rusty1s marked this pull request as ready for review October 9, 2026 02:04
@rusty1s
rusty1s merged commit 1a76c14 into main Oct 9, 2026
4 checks passed
@rusty1s
rusty1s deleted the fix/review-test-randomness-guidance branch October 9, 2026 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants