Skip to content

Align review test randomness guidance with repository policy #1079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rusty1s merged 1 commit into from
Oct 9, 2026
Merged

Align review test randomness guidance with repository policy #1079

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions .coderabbit.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,8 +49,8 @@ reviews:
- path: 'test/**/*.py'
instructions: >-
Pytest-based tests. Check that behavior changes in sdm/ have
corresponding test coverage, randomness is controlled via fixed
seeds or generators, and parametrization covers relevant
corresponding test coverage, seeds or generators are used only
when required by the tested behavior, and parametrization covers relevant
dtype/device variants. Plain pytest functions are preferred over
unittest-style classes.
- path: 'examples/**'
Expand Down Expand Up @@ -125,5 +125,6 @@ code_generation:
instructions: >-
Place tests under test/ mirroring the sdm/ package layout. Use
plain pytest functions with `pytest.mark.parametrize` for
dtype/device variants, fixed seeds or explicit generators for
any randomness, and `sdm.testing` utilities where applicable.
dtype/device variants and `sdm.testing` utilities where applicable.
Do not set seeds unless the tested behavior requires them; use
explicit generators when controlled randomness is necessary.
Loading