fix: Android progress bars show a stray dot at the end - #75
Open
SRWieZ wants to merge 1 commit into
Open
Conversation
Material3 1.7's LinearProgressIndicator draws an expressive stop indicator dot at the track's end plus a gap between the progress tip and the track. On the thin bars this element renders they read as stray dots at both edges — a near-empty bar shows exactly two dots and nothing else. iOS's ProgressView draws a plain continuous bar; match it. Indeterminate bars keep the animated M3 style.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's wrong
A thin determinate
<native:progress-bar>on Android shows a stray dot at its right end. Material3 1.7'sLinearProgressIndicatordraws an "expressive" stop-indicator dot at the track's end plus a gap between the progress tip and the track — on a thin bar a near-empty value reads as two floating dots and not much else. iOS draws a plain continuous bar.Minimum repro:
What this does
Determinate bars pass
gapSize = 0.dpand an emptydrawStopIndicator— a plain continuous bar, matching iOS. Indeterminate bars keep the animated M3 style. Judgment call: if you'd rather keep the M3 expressive look as the Android default, say the word and I'll flip this to an opt-in prop instead. No iOS or PHP changes.Before / after (Android emulator, API 36, same Blade)