Skip to content

fix: Android progress bars show a stray dot at the end #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SRWieZ wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: Android progress bars show a stray dot at the end #75

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions resources/android/ProgressBarRenderer.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import androidx.compose.material3.LinearProgressIndicator
import androidx.compose.runtime.Composable
import androidx.compose.ui.Modifier
import androidx.compose.ui.graphics.Color
import androidx.compose.ui.unit.dp
import androidx.compose.ui.semantics.contentDescription
import androidx.compose.ui.semantics.semantics
import com.nativephp.mobile.ui.nativerender.NativeUINode
Expand Down Expand Up @@ -38,11 +39,19 @@ object ProgressBarRenderer {
trackColor = track,
)
} else {
// Determinate bars drop M3 1.7's expressive extras — the stop
// indicator dot at the track's end and the gap between progress
// tip and track. On the thin bars this element renders they read
// as stray dots at both edges (a near-empty bar shows exactly
// two dots and nothing else), and the iOS renderer's ProgressView
// draws a plain continuous bar — parity wins.
LinearProgressIndicator(
progress = { p.getFloat("value").coerceIn(0f, 1f) },
modifier = barModifier,
color = tint,
trackColor = track,
gapSize = 0.dp,
drawStopIndicator = {},
)
}
}
Expand Down
Loading