Repository navigation
dectnrp_nrf91: first implementation - #1
Conversation
2a98f37 to
de06a80
Compare
|
The build job failed because the Zephyr docker image seems to big for the runner. Mysteriously only "error:" is displayed but not the log itself.
|
cabe394 to
a81fae8
Compare
| repo-path: opener | ||
| # Always use git tag or commit hash as a revision | ||
| revision: main | ||
| revision: dectnrp_nrf91-first-shot |
There was a problem hiding this comment.
Do NOT merge this change!
Before merging this needs to be reverted after Opener-Initiative/opener#3 has been merged!
There was a problem hiding this comment.
- dectnrp_nrf91x1: first driver implementation opener#3 has been merged
- Line has been reverted to main
- Can be merged...
There was a problem hiding this comment.
Do NOT merge this change!
Before merging this needs to be reverted after Opener-Initiative/opener#4 has been merged!
|
|
||
| .. code-block:: bash | ||
|
|
||
| nrfutil sdk-manager toolchain launch --ncs-version v3.1.1 --shell |
There was a problem hiding this comment.
The usage of nrf tools/ sdk-manager should be documented in top level README.md.
6df5889 to
d559efc
Compare
7ee6817 to
18a5633
Compare
a76a21e to
f10aeeb
Compare
|
I changed (hopefully) every occurrence of nrf91 to nrf91x1 (both lower and upper case). |
|
If you are curious where to find logs where the pipeline just shows error: in red: Can not attach a picture here... :( |
f10aeeb to
035a789
Compare
| } | ||
|
|
||
| struct dectnrp_event_wrapper *item = | ||
| k_malloc(sizeof(struct dectnrp_event_wrapper)); |
There was a problem hiding this comment.
I have chosen the simple solution via k_malloc. A more efficient way should be used.
| struct dectnrp_event_wrapper *item = | ||
| k_malloc(sizeof(struct dectnrp_event_wrapper)); | ||
| __ASSERT(item != NULL, "fifo_item == NULL"); | ||
| memcpy(&item->event, event, sizeof(struct dectnrp_driver_event)); |
There was a problem hiding this comment.
I just noticed, only the event gets copied here but not the pcc and pdc memory.
event->msg_received.pcc and event->msg_received.pdc are used asynchronously within receive.
That of course is not correct as meanwile the modem may re-use that memory and its only by chance that it works now.
We could use net_pkt_rx_alloc_with_buffer or some similar function to allocate a packet and copy the message itself to it.
| * @param dev | ||
| * @param event | ||
| */ | ||
| static void dectnrp_driver_event(const struct device *dev, |
There was a problem hiding this comment.
I also think that we should provide struct net_if *iface instead of const struct device *dev.
I did stumble over that problem when I wanted to copy pcc and pdc into a netpkt/netbuf.
Then I needed struct net_pkt *pkt = net_pkt_alloc_with_buffer(iface, .
It also is more consistent as other interface functions of the net framework also have iface.
If needed the driver instance can be retrieved from iface using
const struct device *net_if_get_device(struct net_if *iface).
There was a problem hiding this comment.
For that change we also need to modify the driver api and the nrf91x1 implementation.
b0bdf63 to
e9e1bae
Compare
e9e1bae to
14d3e1a
Compare
po3ts
left a comment
po3ts
left a comment
There was a problem hiding this comment.
This can be merged from my side once the changes from Opener-Initiative/opener#4 are in (and west.yml points to main).
* implement first samples/dectnrp_driver ping-pong example * demonstration get-time and rssi1-scan * demonstrating rx and tx with a simple ping-pong synchronization and communication * add first dectnrp_operation module to manage operations * rework ci by using zephyrproject-rtos/action-zephyr-setup * improve documentation Signed-off-by: Rainer Schubert <rainer.schubert@deveritec.com>
14d3e1a to
5926ab4
Compare
Signed-off-by: Rainer Schubert <rainer.schubert@deveritec.com>
5926ab4 to
09ac2bd
Compare
This PR is meant for setup/build/debugging and test of
You can "easily" follow the steps in README.md. The related branch gets automatically checked out by west.