Repository navigation
drivers:dectnrp:driver_event uses iface - #4
Merged
Merged
Conversation
RainerSchubert
commented
Sep 23, 2026
| const uint8_t *pcc; | ||
| /** Points to PDC. */ | ||
| /** Number of bytes of PCC. */ | ||
| uint8_t pcc_len; |
Member
Author
There was a problem hiding this comment.
I added also a field for length of the pcc.
This is disputable as it is a redundant information - with the field phy_type the length can be retrieved.
RainerSchubert
commented
Sep 23, 2026
| zephyr_library_named(dectnrp_driver) | ||
|
|
||
| zephyr_library_sources_ifdef(CONFIG_DECTNRP_DRIVER_NRF91 | ||
| zephyr_library_sources_ifdef(CONFIG_DECTNRP_DRIVER_NRF91X1 |
Member
Author
There was a problem hiding this comment.
This was a bug which slipped through .. seems I did not run the sample after changing the naming.
RainerSchubert
force-pushed
the
driver-event-has-iface
branch
from
September 23, 2026 19:00
4f48013 to
dfb5632
Compare
Signed-off-by: Rainer Schubert <rainer.schubert@deveritec.com>
* replace device against iface at dectnrp_driver_event_cb_t * add pcc_len field to DECTNRP_EVENT_MSG_RECEIVED event * add warning about scope of pcc, pdc and event pointers Signed-off-by: Rainer Schubert <rainer.schubert@deveritec.com>
RainerSchubert
force-pushed
the
driver-event-has-iface
branch
from
September 23, 2026 19:03
dfb5632 to
34ee6c6
Compare
Member
|
@Opener-Initiative/tsg can we merge the #4 and Opener-Initiative/opener-samples#1 ???? After with i will create a Pull Request for migration-to-ncs-3.4.0 |
nor-bot
approved these changes
Sep 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The stack need the related interface together with the called
dectnrp_driver_event_cb_t. For example when creating net_pkt/net_buf and also other net functions the iface is needed.The related radio driver device can be retrieved via
const struct device *net_if_get_device(struct net_if *iface).