Skip to content

better root find#2199

Open
unalmis wants to merge 23 commits into
ku/sparse_pullbackfrom
ku/condition_number
Open

better root find#2199
unalmis wants to merge 23 commits into
ku/sparse_pullbackfrom
ku/condition_number

Conversation

@unalmis
Copy link
Copy Markdown
Collaborator

@unalmis unalmis commented May 1, 2026 •
edited
Loading

PR Age

Resolves #2157 (comment) .

  • formula advertised in numerical recipes not backwards stable. causes issues. resolves that
  • better continuity invariant preservation

Otherwise you get fake roots like this where condition number becomes singular, which poisons proceeding algorithm. Resolves that.

Screenshot From 2026-04-29 23-32-15

@unalmis unalmis requested review from daniel-dudt, ddudt and f0uriest May 1, 2026 00:13
@unalmis unalmis added the easy Short and simple to code or review label May 1, 2026
@unalmis unalmis changed the title Ku/condition number resolve singular condition number in root find May 1, 2026
@unalmis unalmis added the bug fix Something was fixed label May 1, 2026
@unalmis unalmis mentioned this pull request May 1, 2026
Merged
@unalmis unalmis added the stable Besides merging master, other updates require a child PR that should be merged to master later. label May 1, 2026
unalmis
unalmis commented May 1, 2026
View reviewed changes
Comment thread tests/inputs/master_compute_data_rpz.pkl
@unalmis unalmis requested a review from dpanici May 1, 2026 01:30
@unalmis unalmis changed the title resolve singular condition number in root find better filtering in root find May 2, 2026
@unalmis unalmis added P1 Lowest Priority, will get to eventually and removed bug fix Something was fixed stable Besides merging master, other updates require a child PR that should be merged to master later. labels May 2, 2026
@unalmis unalmis marked this pull request as draft May 2, 2026 06:08
@unalmis unalmis added robustness Make the code more robust and removed easy Short and simple to code or review P1 Lowest Priority, will get to eventually labels May 2, 2026
@unalmis unalmis marked this pull request as ready for review May 2, 2026 11:20
@unalmis unalmis requested review from ddudt, dpanici and f0uriest May 2, 2026 12:12
@unalmis unalmis added the stable Besides merging master, other updates require a child PR that should be merged to master later. label May 2, 2026
@unalmis unalmis changed the title better filtering in root find better root find May 2, 2026
@unalmis unalmis self-assigned this May 2, 2026
f0uriest
f0uriest approved these changes May 17, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@f0uriest f0uriest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine but for ease of review please don't merge into #2168, wait until that is approved and merge both into master 1 by 1

@unalmis unalmis mentioned this pull request May 18, 2026
Open
5 tasks
@unalmis unalmis added approved and removed stable Besides merging master, other updates require a child PR that should be merged to master later. labels May 19, 2026
@unalmis unalmis mentioned this pull request May 28, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@f0uriest f0uriest f0uriest approved these changes

@ddudt ddudt Awaiting requested review from ddudt

@dpanici dpanici Awaiting requested review from dpanici

Assignees

@unalmis unalmis

Labels

approved robustness Make the code more robust

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@unalmis @f0uriest