Repository navigation
feat(friends): add GetUserFriendPIDsMulti rpc - #32
Merged
Merged
Conversation
Contributor
|
The latest Buf updates on your PR. Results from workflow Validate Pull Request / check_buf (pull_request).
|
… to service proto
DaniElectra
approved these changes
Nov 11, 2026
DaniElectra
left a comment
Member
There was a problem hiding this comment.
LGTM. By the way, since friends only implements the "get user data" rpcs on v2, we are still in time to update the original GetUserFriendPIDs RPC to use uint64 here too
Member
Author
Oh perfect! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #XXX
Changes:
Adds a
GetUserFriendPIDsMultirpc to thefriends.v2service. This lets callers get the friends lists of multiple users in one callThis is essential for PretendoNetwork/nex-protocols-common-go#53 since some RMCs can request up to 100 users friends lists, and pulling those one at a time sucks. The response uses a
mapkeyed by the PID whom that list belongs to, so we don't have to worry about making sure the PID lists reach the caller in the same order they were requested inI also took the liberty of using
uint64for the PID size here. This breaks the convention of using auint32, but that convention was wrong anyway and breaks compatibility with NEX 4.0+ games. I'm planning to later makeV2versions of all these rpcs anyway that switch to theuint64size, but that's out of scope for this right now