Skip to content

feat(friends): add GetUserFriendPIDsMulti rpc - #32

Merged
jonbarrow merged 3 commits into
masterfrom
feat/friends-multiple-friend-lists
Nov 11, 2026
Merged

jonbarrow merged 3 commits into
masterfrom
feat/friends-multiple-friend-lists

Conversation

@jonbarrow

Copy link
Copy Markdown
Member

Resolves #XXX

Changes:

Adds a GetUserFriendPIDsMulti rpc to the friends.v2 service. This lets callers get the friends lists of multiple users in one call

This is essential for PretendoNetwork/nex-protocols-common-go#53 since some RMCs can request up to 100 users friends lists, and pulling those one at a time sucks. The response uses a map keyed by the PID whom that list belongs to, so we don't have to worry about making sure the PID lists reach the caller in the same order they were requested in

I also took the liberty of using uint64 for the PID size here. This breaks the convention of using a uint32, but that convention was wrong anyway and breaks compatibility with NEX 4.0+ games. I'm planning to later make V2 versions of all these rpcs anyway that switch to the uint64 size, but that's out of scope for this right now

@github-actions

github-actions Bot commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor

The latest Buf updates on your PR. Results from workflow Validate Pull Request / check_buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed⏩ skipped✅ passed✅ passedNov 11, 2026, 5:17 PM

@DaniElectra DaniElectra left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. By the way, since friends only implements the "get user data" rpcs on v2, we are still in time to update the original GetUserFriendPIDs RPC to use uint64 here too

@jonbarrow

Copy link
Copy Markdown
Member Author

LGTM. By the way, since friends only implements the "get user data" rpcs on v2, we are still in time to update the original GetUserFriendPIDs RPC to use uint64 here too

Oh perfect!

@jonbarrow
jonbarrow merged commit e2888b4 into master Nov 11, 2026
3 checks passed
@jonbarrow
jonbarrow deleted the feat/friends-multiple-friend-lists branch November 11, 2026 19:35
@jonbarrow jonbarrow mentioned this pull request Nov 11, 2026
2 of 4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants