Add canopen to build#167
Conversation
|
What is the error when using the older sysroot version? |
|
It will result in the following error: The relevant file for the first error is https://github.com/torvalds/linux/blob/master/include/linux/can/bittiming.h |
|
@wolfv suggested the right solution, we should add an option to set a custom variant.yaml in the recipe that require a |
|
Needs RoboStack/vinca#114 |
|
I updated the PR by add more canopen packages explicitly (they are not all dependencies of the general canopen package). I also merged the upstream changes to resolve conflicts. |
|
The failing Windows CI seems not to be related as this PR only adds Linux packages. |
Tobias-Fischer
left a comment
There was a problem hiding this comment.
We need RoboStack/vinca#114 first before we can merge here.
Ping @wolfv
| - vs # [win] | ||
| c_stdlib_version: # [unix] | ||
| - 2.17 # [linux] | ||
| - 2.28 # [linux] |
There was a problem hiding this comment.
I'm reluctant to do that. See RoboStack/vinca#114 instead.
This PR adds building for the canopen packages, including its dependency on ros-jazzy-lely-core-libraries.
Since lely-core-libraries relies on newer linux CAN header files, the c_stdlib_version needs to be higher for this package. I tried to add
to the dependencies.yaml, however this does not work because then the depency will be listed two times in the generated reciepe.yaml. I am not sure if this is really a change that you want to merge. Feel free to reject this PR. In that case people can still find it here if they want to build lely-core-libraries on their own.
The patch file is also ugly. I spend a lot of time debugging the build of lely-core-libraries and this was the best I could come up with. It first installs everthing to an intermediate folder and then installs it from there to the final destination.