DPL negotiation default algorithm#4186
DPL negotiation default algorithm#4186openroad-ci wants to merge 15 commits intoThe-OpenROAD-Project:masterfrom
Conversation
Signed-off-by: Augusto Berndt <augusto.berndt@precisioninno.com>
replace USE_NEGOTIATION for DPL_USE_OLD_DIAMOND, since the OR submodule now does not have -use_negotiation anymore for dpl, and has -use_old_diamond, the default is negotiation legalizer Signed-off-by: Augusto Berndt <augusto.berndt@precisioninno.com>
There was a problem hiding this comment.
Code Review
This pull request updates the OpenROAD subproject, reduces core utilization for several designs, and renames the USE_NEGOTIATION variable to DPL_USE_OLD_DIAMOND to reflect that the negotiation legalizer is now the default. Feedback suggests removing leftover debug code in global_route.tcl and adding the stages field to the new variable definition in the configuration files for improved documentation and consistency.
| #set_debug_level DPL negotiation 1 | ||
| dpl::detailed_placement_debug | ||
| log_cmd detailed_placement {*}$dpl_args |
There was a problem hiding this comment.
| "DPL_USE_OLD_DIAMOND": { | ||
| "default": 0, | ||
| "description": "Enable using negotiation legalizer for detailed placement.\n" | ||
| "description": "Use the former diamond search legalizer for detailed placement instead of the default negotiation legalizer.\n" | ||
| }, |
There was a problem hiding this comment.
It is recommended to include the stages field for the new DPL_USE_OLD_DIAMOND variable to document where it is used (place, cts, and grt) and to maintain consistency with other variables in this file.
"DPL_USE_OLD_DIAMOND": {
"default": 0,
"description": "Use the former diamond search legalizer for detailed placement instead of the default negotiation legalizer.\n",
"stages": [
"place",
"cts",
"grt"
]
},| DPL_USE_OLD_DIAMOND: | ||
| description: | | ||
| Enable using negotiation legalizer for detailed placement. | ||
| Use the former diamond search legalizer for detailed placement instead of the default negotiation legalizer. | ||
| default: 0 |
There was a problem hiding this comment.
To maintain consistency with variables.json and other documented variables, consider adding the stages field here as well.
DPL_USE_OLD_DIAMOND:
description: |
Use the former diamond search legalizer for detailed placement instead of the default negotiation legalizer.
default: 0
stages:
- place
- cts
- grtSigned-off-by: Augusto Berndt <augusto.berndt@precisioninno.com>
Signed-off-by: Augusto Berndt <augusto.berndt@precisioninno.com>
This PR updates metrics for OR PR The-OpenROAD-Project/OpenROAD#10226 to make new negotiation legalizer algorithm into the default one.
This PR also replaces USE_NEGOTIATION for DPL_USE_OLD_DIAMOND, since the OR submodule now does not have
-use_negotiationanymore for dpl, and has-use_old_diamond.I also modified the utilization of a few failing designs.