Repository navigation
Build/QA: Retire identical.alwaysTrue PHPStan baseline - #14032
huzaifaalmesbah wants to merge 2 commits into
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
…ntical-always-true # Conflicts: # src/wp-includes/class-wp.php # tests/phpstan/baselines/identical.alwaysTrue.neon
Description
Retires the
identical.alwaysTruePHPStan baseline in WordPress core by removing a redundant comparison and adding a targeted type annotation:File_Upload_Upgrader: In the plugin/theme archive check, because'pluginzip'was already matched above, the remaining branch is always'themezip'. Simplifiedif ( 'themezip' === $form )toelse.rest_filter_response_fields(): Annotated$fields_as_keyedasarray<string, mixed>to clarify the nested array structure to PHPStan without redundant strict comparison warnings.The always-true
'404' === $errorcheck inWP::parse_request()was already removed in r64244, so these are the last two errors andidentical.alwaysTrue.neonis retired.Testing Instructions
Run static analysis:
Confirm 0 errors are found.
Run PHPCS:
Confirm standards compliance.
Trac ticket: https://core.trac.wordpress.org/ticket/65817
Use of AI Tools
AI assistance: Yes
Tool(s): Google Antigravity
Model(s): Gemini 3.8 Flash
Used for: Researching static analysis reports and drafting initial baseline diffs; all logic, type declarations, and analysis results were manually investigated, verified, and run locally by me.