Skip to content

Build/QA: Retire identical.alwaysTrue PHPStan baseline - #14032

Open
huzaifaalmesbah wants to merge 2 commits into
WordPress:trunkfrom
huzaifaalmesbah:phpstan/retire-identical-always-true
Open

huzaifaalmesbah wants to merge 2 commits into
WordPress:trunkfrom
huzaifaalmesbah:phpstan/retire-identical-always-true

Conversation

@huzaifaalmesbah

@huzaifaalmesbah huzaifaalmesbah commented Oct 6, 2026 •

Copy link
Copy Markdown
Member

Description

Retires the identical.alwaysTrue PHPStan baseline in WordPress core by removing a redundant comparison and adding a targeted type annotation:

  1. File_Upload_Upgrader: In the plugin/theme archive check, because 'pluginzip' was already matched above, the remaining branch is always 'themezip'. Simplified if ( 'themezip' === $form ) to else.
  2. rest_filter_response_fields(): Annotated $fields_as_keyed as array<string, mixed> to clarify the nested array structure to PHPStan without redundant strict comparison warnings.

The always-true '404' === $error check in WP::parse_request() was already removed in r64244, so these are the last two errors and identical.alwaysTrue.neon is retired.

Testing Instructions

  1. Run static analysis:

    composer phpstan

    Confirm 0 errors are found.

  2. Run PHPCS:

    vendor/bin/phpcs src/wp-admin/includes/class-file-upload-upgrader.php src/wp-includes/rest-api.php

    Confirm standards compliance.

Trac ticket: https://core.trac.wordpress.org/ticket/65817

Use of AI Tools

AI assistance: Yes
Tool(s): Google Antigravity
Model(s): Gemini 3.8 Flash
Used for: Researching static analysis reports and drafting initial baseline diffs; all logic, type declarations, and analysis results were manually investigated, verified, and run locally by me.

@github-actions

github-actions Bot commented Oct 6, 2026

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props huzaifaalmesbah.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions

github-actions Bot commented Oct 6, 2026

Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

…ntical-always-true

# Conflicts:
#	src/wp-includes/class-wp.php
#	tests/phpstan/baselines/identical.alwaysTrue.neon
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant