Skip to content

Build/QA: Retire identical.alwaysTrue PHPStan baseline #14032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
huzaifaalmesbah wants to merge 2 commits into
base: trunk
Choose a base branch
from
Open

Build/QA: Retire identical.alwaysTrue PHPStan baseline #14032

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4d4715c
Code Quality: Remove redundant comparisons in upgrader, query parsing…
huzaifaalmesbah Oct 6, 2026
1db817a
Merge remote-tracking branch 'upstream/trunk' into phpstan/retire-ide…
huzaifaalmesbah Oct 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion phpstan.neon.dist
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,6 @@ includes:
- tests/phpstan/baselines/function.resultUnused.neon
- tests/phpstan/baselines/greaterOrEqual.alwaysTrue.neon
- tests/phpstan/baselines/identical.alwaysFalse.neon
- tests/phpstan/baselines/identical.alwaysTrue.neon
- tests/phpstan/baselines/if.alwaysFalse.neon
- tests/phpstan/baselines/if.alwaysTrue.neon
- tests/phpstan/baselines/isset.offset.neon
Expand Down
4 changes: 1 addition & 3 deletions src/wp-admin/includes/class-file-upload-upgrader.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,9 +80,7 @@ public function __construct( $form, $urlholder ) {
__( 'Return to the Plugin Installer' )
);
wp_die( __( 'Incompatible Archive.' ) . '<br />' . $plugins_page );
}

if ( 'themezip' === $form ) {
} else {
$themes_page = sprintf(
'<a href="%s" target="_parent">%s</a>',
self_admin_url( 'theme-install.php' ),
Expand Down
1 change: 1 addition & 0 deletions src/wp-includes/rest-api.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -965,6 +965,7 @@ function rest_filter_response_fields( $response, $server, $request ) {
$fields = array_map( 'trim', $fields );

// Create nested array of accepted field hierarchy.
/** @var array<string, mixed> $fields_as_keyed */
$fields_as_keyed = array();
foreach ( $fields as $field ) {
$parts = explode( '.', $field );
Expand Down
30 changes: 0 additions & 30 deletions tests/phpstan/baselines/identical.alwaysTrue.neon
View file
Open in desktop

This file was deleted.

Loading