Fix Function.get_window() crash when there is no OVER clause#866
Open
uttam12331 wants to merge 1 commit into
Open
Fix Function.get_window() crash when there is no OVER clause#866uttam12331 wants to merge 1 commit into
uttam12331 wants to merge 1 commit into
Conversation
token_next_by() returns a (idx, token) tuple, which is always truthy, so 'if not over_clause' never triggered; when a function had no OVER clause, over_clause[1] was None and over_clause[1].tokens[-1] raised AttributeError instead of returning None. Guard on the token, matching the sibling get_parameters().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Function.get_window()raisesAttributeErrorfor any function without anOVERclause:token_next_by()returns an(idx, token)tuple —(None, None)when nothing matches. A tuple is always truthy, so the existingif not over_clause:guard is dead code and never returnsNone; execution falls through toover_clause[1].tokens[-1], andover_clause[1]isNone.Fix
Guard on the token instead of the tuple, matching the sibling
get_parameters()in the same class (which usestoken_next_by(i=Parenthesis)[1]):The
OVER-present paths are unchanged (window token still returned); only the no-OVERcase now correctly returnsNone.Tests
Added a negative-path assertion to
test_grouping_function(foo(5)→get_window() is None). Full suite passes locally (487 passed).