Skip to content

Fix Function.get_window() crash when there is no OVER clause #866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
uttam12331 wants to merge 1 commit into
base: master
Choose a base branch
from
+5 −1
Open

Fix Function.get_window() crash when there is no OVER clause #866

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sqlparse/sql.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -638,7 +638,7 @@ def get_parameters(self):
def get_window(self):
"""Return the window if it exists."""
over_clause = self.token_next_by(i=Over)
if not over_clause:
if over_clause[1] is None:
return None
return over_clause[1].tokens[-1]

Expand Down
4 changes: 4 additions & 0 deletions tests/test_grouping.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -393,6 +393,10 @@ def test_grouping_function():
assert isinstance(p.tokens[0], sql.Function)
assert len(list(p.tokens[0].get_parameters())) == 1
assert isinstance(p.tokens[0].get_window(), sql.Parenthesis)
# A function without an OVER clause has no window.
p = sqlparse.parse('foo(5)')[0]
assert isinstance(p.tokens[0], sql.Function)
assert p.tokens[0].get_window() is None


def test_grouping_function_not_in():
Expand Down