Skip to content

fix long screen issue#381

Closed
ardeshiir wants to merge 2 commits intoankeetmaini:masterfrom
Stacrypt:fix_zoomed_out_issue
Closed

fix long screen issue#381
ardeshiir wants to merge 2 commits intoankeetmaini:masterfrom
Stacrypt:fix_zoomed_out_issue

Conversation

@ardeshiir
Copy link
Copy Markdown

@ardeshiir ardeshiir force-pushed the fix_zoomed_out_issue branch from 6d1bacf to 51937f7 Compare May 2, 2023 09:16
@ardeshiir ardeshiir closed this May 2, 2023
@ardeshiir ardeshiir reopened this May 2, 2023
@iamdarshshah
Copy link
Copy Markdown
Collaborator

Thanks for the fix. The "content doesn't fill the viewport on initial load" problem is real, and worth acknowledging. The v7.0.0 rewrite handles this naturally through the IntersectionObserver sentinel: as long as the sentinel div remains visible in the viewport, next() keeps getting triggered, so the manual post-load height check is no longer needed. Closing as superseded.

If you'd like to keep contributing, check out the open issues or file a new one if you find something worth fixing. Looking forward to more contributions from you, let's make this the best infinite scroll library out there!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants