fix: Strip prefix in PrefixStore::get_opts#670
Closed
liamdiprose wants to merge 1 commit intoapache:mainfrom
Closed
fix: Strip prefix in PrefixStore::get_opts#670liamdiprose wants to merge 1 commit intoapache:mainfrom
liamdiprose wants to merge 1 commit intoapache:mainfrom
Conversation
liamdiprose
force-pushed
the
fix/strip-prefix
branch
from
bb53bd4 to
bdfbc9b
Compare
Contributor
|
this needs a regression test |
Contributor
|
Friendly ping, we're running into an issue related to this so would be great to get this PR over the line. I think this breaks listing table in datafusion 53 cc @alamb |
Contributor
|
@asubiotto feel free to pick this up (filing a new PR, since you don't have edit permissions I think) and add a regression test. |
Contributor
|
Done: #686 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #664
What changes are included in this PR?
Calls strip_meta on the
.metafield of theGetResultfrom the inner store of the PrefixStore.Are there any user-facing changes?
The meta.location coming from PrefixStore::head, get_opts, etc no longer has the prefix. I can't imagine anyone relying on the functionality of this bug.