fix[prefix]: strip_meta from get_opts result in PrefixStore#686
Merged
crepererum merged 1 commit intoapache:mainfrom Apr 8, 2026
Merged
fix[prefix]: strip_meta from get_opts result in PrefixStore#686crepererum merged 1 commit intoapache:mainfrom
crepererum merged 1 commit intoapache:mainfrom
Conversation
PrefixStore was incorrectly not stripping the prefix from the returned result. Signed-off-by: Alfonso Subiotto Marques <alfonso.subiotto@polarsignals.com>
Contributor
Author
|
cc @crepererum |
crepererum
approved these changes
Apr 8, 2026
| assert_eq!(&*read_data, data) | ||
| } | ||
|
|
||
| // Regression test for |
Contributor
There was a problem hiding this comment.
the extensions of the integration test is actually sufficient, but having an additional regression test also doesn't hurt.
Contributor
Author
|
Thanks for the review! Can I/how do I request that this gets backported to 0.13? |
Contributor
|
None of the breaking changes for 0.14.x have landed yet, so backporting is technically not even required. I will however note this in #672 so we don't forget. |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PrefixStore was incorrectly not stripping the prefix from the returned result.
Which issue does this PR close?
Closes #664
Closes #670
Rationale for this change
Fix regression
What changes are included in this PR?
Fix + assertion in integration tests + regression test
Are there any user-facing changes?