GH-49057: [Python][Packaging] Remove test base docker image and use single windows base image for both build and test containers #48996

raulcd · 2026-01-26T16:45:10Z

Rationale for this change

This PR removes some duplication by removing ci/docker/python-wheel-windows-test-vs2022-base.dockerfile in order to use a single base image python-wheel-windows-vs2022-base for both building and testing docker containers.

What changes are included in this PR?

Remove python-wheel-windows-test-base and the related dockerfile.
Add some requirements for test (minio and test_gcs) on base image so it's available everywhere.
Remove manual installation of python on docker images or via choco. This will be only done via pymanager which is installed on the base image.

Are these changes tested?

Yes via archery on CI.

Are there any user-facing changes?

No

GitHub Issue: [Python][Packaging] Merge Windows wheels base and test base images into a single image #49057

raulcd · 2026-01-26T16:45:38Z

@github-actions crossbow submit wheel-windows-cp314-cp314-amd64

github-actions · 2026-01-26T16:47:59Z

Revision: cb51469

Submitted crossbow builds: ursacomputing/crossbow @ actions-ff4f1aab24

Task	Status
wheel-windows-cp314-cp314-amd64

raulcd · 2026-01-27T08:10:36Z

@github-actions crossbow submit wheel-windows-cp314-cp314t-amd64

github-actions · 2026-01-27T08:12:53Z

Revision: cb51469

Submitted crossbow builds: ursacomputing/crossbow @ actions-7fa4698ac5

Task	Status
wheel-windows-cp314-cp314t-amd64

raulcd · 2026-01-27T13:43:01Z

@github-actions crossbow submit wheel-windows-cp314-cp314t-amd64

github-actions · 2026-01-27T13:45:41Z

Revision: 054b8dc

Submitted crossbow builds: ursacomputing/crossbow @ actions-9f6150165d

Task	Status
wheel-windows-cp314-cp314t-amd64

raulcd · 2026-01-27T18:47:30Z

@github-actions crossbow submit wheel-windows-cp314-cp314t-amd64

github-actions · 2026-01-27T18:49:42Z

Revision: a07afbf

Submitted crossbow builds: ursacomputing/crossbow @ actions-ef0cfd85af

Task	Status
wheel-windows-cp314-cp314t-amd64

raulcd · 2026-01-28T08:34:27Z

@github-actions crossbow submit wheel-windows-cp314-cp314t-amd64

github-actions · 2026-01-28T08:36:38Z

Revision: e1ab7da

Submitted crossbow builds: ursacomputing/crossbow @ actions-2eb2d5cfd2

Task	Status
wheel-windows-cp314-cp314t-amd64

raulcd · 2026-01-28T12:11:29Z

@github-actions crossbow submit wheel-windows-*

github-actions · 2026-01-28T12:13:54Z

Revision: 6665098

Submitted crossbow builds: ursacomputing/crossbow @ actions-d8042cc7a1

Task	Status
wheel-windows-cp310-cp310-amd64
wheel-windows-cp311-cp311-amd64
wheel-windows-cp312-cp312-amd64
wheel-windows-cp313-cp313-amd64
wheel-windows-cp313-cp313t-amd64
wheel-windows-cp314-cp314-amd64
wheel-windows-cp314-cp314t-amd64

raulcd · 2026-01-28T12:24:29Z

@github-actions crossbow submit wheel-windows-cp314-cp314t-amd64

github-actions · 2026-01-28T12:26:46Z

Revision: 2aa3a1f

Submitted crossbow builds: ursacomputing/crossbow @ actions-22c758b35f

Task	Status
wheel-windows-cp314-cp314t-amd64

raulcd · 2026-01-28T15:44:58Z

@github-actions crossbow submit wheel-windows-cp314-cp314t-amd64

github-actions · 2026-01-28T15:47:18Z

Revision: 1ca2938

Submitted crossbow builds: ursacomputing/crossbow @ actions-a84a844d69

Task	Status
wheel-windows-cp314-cp314t-amd64

raulcd · 2026-01-29T09:37:26Z

@github-actions crossbow submit wheel-windows-*

github-actions · 2026-01-29T09:39:48Z

Revision: 1ca2938

Submitted crossbow builds: ursacomputing/crossbow @ actions-bb12f9cd6a

Task	Status
wheel-windows-cp310-cp310-amd64
wheel-windows-cp311-cp311-amd64
wheel-windows-cp312-cp312-amd64
wheel-windows-cp313-cp313-amd64
wheel-windows-cp313-cp313t-amd64
wheel-windows-cp314-cp314-amd64
wheel-windows-cp314-cp314t-amd64

github-actions · 2026-01-29T09:48:34Z

⚠️ GitHub issue #49057 has been automatically assigned in GitHub to PR creator.

raulcd · 2026-01-29T09:53:07Z

This PR is only to merge installing build tools, pymanager and other dependencies in a single base to be used by build and test images so we don't have to manage installing pymanager or python via choco on a bunch of different places.

pitrou · 2026-01-29T10:06:08Z

ci/docker/python-wheel-windows-vs2022-base.dockerfile

+
+# Install the GCS testbench using a well-known Python version.
+# NOTE: cannot use pipx's `--fetch-missing-python` because of
+# https://github.com/pypa/pipx/issues/1521, therefore download Python ourselves.


It seems the pipx issue was solved, should we reconsider this?

Or we can use pymanager instead of choco, I don't know. (but this might be fine anyway)

We still would require to install python manually (either via choco or pymanager) to pip install pipx, right? As the base image won't have any python by default. I don't understand what the --fetch-missing-python problem was trying to solve on that specific case.
I am fine trying to install Python here with pymanager instead of choco.

Ah, I think the image had some Python installed before. If choco works fine then we can probably keep it for now...

raulcd · 2026-01-29T10:48:07Z

@github-actions crossbow submit wheel-windows-cp313-cp313-amd64

github-actions · 2026-01-29T10:50:41Z

Revision: 73ca678

Submitted crossbow builds: ursacomputing/crossbow @ actions-17f326e4c3

Task	Status
wheel-windows-cp313-cp313-amd64

raulcd · 2026-01-29T11:26:49Z

@github-actions crossbow submit wheel-windows-cp313-cp313-amd64

github-actions · 2026-01-29T11:29:02Z

Revision: 8bbf7d5

Submitted crossbow builds: ursacomputing/crossbow @ actions-437184cc2f

Task	Status
wheel-windows-cp313-cp313-amd64

raulcd · 2026-01-29T14:28:47Z

@github-actions crossbow submit wheel-windows-cp313-cp313-amd64

github-actions · 2026-01-29T14:31:01Z

Revision: 8e8cd87

Submitted crossbow builds: ursacomputing/crossbow @ actions-f107a3ffcb

Task	Status
wheel-windows-cp313-cp313-amd64

…ase image

raulcd · 2026-01-30T09:53:00Z

@github-actions crossbow submit wheel-windows-cp313-cp313-amd64

github-actions · 2026-01-30T09:57:40Z

Revision: eac026f

Submitted crossbow builds: ursacomputing/crossbow @ actions-19c432ac62

Task	Status
wheel-windows-cp313-cp313-amd64

raulcd · 2026-01-30T14:02:17Z

@github-actions crossbow submit wheel-windows-cp313-cp313-amd64

github-actions · 2026-01-30T14:04:27Z

Revision: 98410dd

Submitted crossbow builds: ursacomputing/crossbow @ actions-7cf85758e1

Task	Status
wheel-windows-cp313-cp313-amd64

github-actions bot added the awaiting committer review Awaiting committer review label Jan 26, 2026

WIP: [Python] Simplify Windows wheel build ecosystem

ac76f96

raulcd force-pushed the simplify-windows-docker-setup branch from cb51469 to ac76f96 Compare January 27, 2026 10:31

Add python_variant_suffix for testing free-threaded

054b8dc

Try upgrading wheel windows image revision

a07afbf

Fix base image

e1ab7da

Remove unnecessary change

6665098

raulcd changed the title ~~WIP: [Python] Simplify Windows wheel build ecosystem~~ WIP: [Python] Remove test base docker image and use single windows base image for both build and test containers Jan 28, 2026

Base for testing images should be the base image not the build image

2aa3a1f

Dockerfiles for test should specify PYTHON_CMD

1ca2938

raulcd changed the title ~~WIP: [Python] Remove test base docker image and use single windows base image for both build and test containers~~ GH-49057: [Python][Packaging] Remove test base docker image and use single windows base image for both build and test containers Jan 29, 2026

raulcd marked this pull request as ready for review January 29, 2026 09:50

raulcd requested review from assignUser, jonkeane and kou as code owners January 29, 2026 09:50

raulcd requested review from AlenkaF and pitrou January 29, 2026 09:50

pitrou reviewed Jan 29, 2026

View reviewed changes

github-actions bot added awaiting changes Awaiting changes and removed awaiting committer review Awaiting committer review labels Jan 29, 2026

github-actions bot added awaiting change review Awaiting change review and removed awaiting changes Awaiting changes labels Jan 29, 2026

Use pymanager to install Python for GCS testbench

f4d33c2

raulcd force-pushed the simplify-windows-docker-setup branch from 8e8cd87 to f4d33c2 Compare January 30, 2026 09:48

Try removing python installation and see if there's a python on the b…

eac026f

…ase image

Use base image Python instead for gcs

98410dd

GH-49057: [Python][Packaging] Remove test base docker image and use single windows base image for both build and test containers #48996

Are you sure you want to change the base?

GH-49057: [Python][Packaging] Remove test base docker image and use single windows base image for both build and test containers #48996

Uh oh!

Conversation

raulcd commented Jan 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

Uh oh!

raulcd commented Jan 26, 2026

Uh oh!

github-actions bot commented Jan 26, 2026

Uh oh!

raulcd commented Jan 27, 2026

Uh oh!

github-actions bot commented Jan 27, 2026

Uh oh!

raulcd commented Jan 27, 2026

Uh oh!

github-actions bot commented Jan 27, 2026

Uh oh!

raulcd commented Jan 27, 2026

Uh oh!

github-actions bot commented Jan 27, 2026

Uh oh!

raulcd commented Jan 28, 2026

Uh oh!

github-actions bot commented Jan 28, 2026

Uh oh!

raulcd commented Jan 28, 2026

Uh oh!

github-actions bot commented Jan 28, 2026

Uh oh!

raulcd commented Jan 28, 2026

Uh oh!

github-actions bot commented Jan 28, 2026

Uh oh!

raulcd commented Jan 28, 2026

Uh oh!

github-actions bot commented Jan 28, 2026

Uh oh!

raulcd commented Jan 29, 2026

Uh oh!

github-actions bot commented Jan 29, 2026

Uh oh!

github-actions bot commented Jan 29, 2026

Uh oh!

raulcd commented Jan 29, 2026

Uh oh!

pitrou Jan 29, 2026

Choose a reason for hiding this comment

Uh oh!

pitrou Jan 29, 2026

Choose a reason for hiding this comment

Uh oh!

raulcd Jan 29, 2026

Choose a reason for hiding this comment

Uh oh!

pitrou Jan 29, 2026

Choose a reason for hiding this comment

Uh oh!

raulcd commented Jan 29, 2026

Uh oh!

github-actions bot commented Jan 29, 2026

Uh oh!

raulcd commented Jan 29, 2026

Uh oh!

github-actions bot commented Jan 29, 2026

Uh oh!

raulcd commented Jan 29, 2026

Uh oh!

github-actions bot commented Jan 29, 2026

Uh oh!

raulcd commented Jan 30, 2026

Uh oh!

github-actions bot commented Jan 30, 2026

Uh oh!

raulcd commented Jan 26, 2026 •

edited

Loading