GH-49042: [C++] Remove mimalloc patch

[pitrou]

Rationale for this change

This patch was integrated upstream in microsoft/mimalloc#1139

Are these changes tested?

By existing CI.

Are there any user-facing changes?

No.

• GitHub Issue: [C++] Remove obsolete mimalloc patch #49042

[github-actions]

Thanks for opening a pull request!

If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose

Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project.

Then could you also rename the pull request title in the following format?

GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

or

MINOR: [${COMPONENT}] ${SUMMARY}

See also:

• Other pull requests
• Contribution Guidelines - Contributing Overview

[pitrou]

@github-actions crossbow submit -g cpp

[github-actions]

Revision: 4aeff20

Submitted crossbow builds: ursacomputing/crossbow @ actions-5539a1b788

Task	Status
example-cpp-minimal-build-static
example-cpp-minimal-build-static-system-dependency
example-cpp-tutorial
test-build-cpp-fuzz
test-conda-cpp
test-conda-cpp-valgrind
test-debian-12-cpp-amd64
test-debian-12-cpp-i386
test-debian-experimental-cpp-gcc-15
test-fedora-42-cpp
test-ubuntu-22.04-cpp
test-ubuntu-22.04-cpp-20
test-ubuntu-22.04-cpp-bundled
test-ubuntu-22.04-cpp-emscripten
test-ubuntu-22.04-cpp-no-threading
test-ubuntu-24.04-cpp
test-ubuntu-24.04-cpp-bundled-offline
test-ubuntu-24.04-cpp-gcc-13-bundled
test-ubuntu-24.04-cpp-gcc-14
test-ubuntu-24.04-cpp-minimal-with-formats
test-ubuntu-24.04-cpp-thread-sanitizer

[raulcd]

We added patch on a bunch of places for this to work. We can probably remove that now, right?
See the original commit:
e1f727c

We only use patch on thrift but that seems to be only required for Clang, this was there prior to the mimalloc change and installing patch wasn't required before.

arrow/cpp/cmake_modules/ThirdpartyToolchain.cmake

Lines 1751 to 1759 in 811a273

	if(CMAKE_CXX_COMPILER_ID STREQUAL "Clang")
	find_program(PATCH patch)
	if(PATCH)
	list(APPEND
	THRIFT_PATCH_COMMAND
	${PATCH}
	-p1
	-i)
	else()

[pitrou]

As you prefer, but patch is a small and generally useful utility, so I don't think we gain much by removing it?

For example 248 kB on Debian 13, with no dependencies except libc:

# LANG=C apt show patch
Package: patch
Version: 2.8-2
Status: install ok installed
Priority: optional
Section: vcs
Maintainer: Laszlo Boszormenyi (GCS) <[email protected]>
Installed-Size: 248 kB
Depends: libc6 (>= 2.34)
Suggests: ed, diffutils-doc

[raulcd]

fair enough, we probably have a bunch of dependencies on several docker images that are not required anymore and patch isn't going to be the problematic one:

        autoconf \
        ccache \
        clang-${llvm} \
        cmake \
        curl \
        g++ \
        gcc \
        gdb \
        git \
        libbenchmark-dev \
        libboost-filesystem-dev \
        libboost-system-dev \
        libbrotli-dev \
        libbz2-dev \
        libc-ares-dev \
        libcurl4-openssl-dev \
        libgflags-dev \
        libgmock-dev \
        libgoogle-glog-dev \
        libgrpc++-dev \
        libidn2-dev \
        libkrb5-dev \
        libldap-dev \
        liblz4-dev \
        libnghttp2-dev \
        libprotobuf-dev \
        libprotoc-dev \
        libpsl-dev \
        libre2-dev \
        librtmp-dev \
        libsnappy-dev \
        libsqlite3-dev \
        libssh-dev \
        libssh2-1-dev \
        libssl-dev \
        libthrift-dev \
        libutf8proc-dev \
        libxml2-dev \
        libxsimd-dev \
        libzstd-dev \
        llvm-${llvm}-dev \
        make \
        ninja-build \
        nlohmann-json3-dev \
        npm \
        opentelemetry-cpp-dev \
        patch \
        pkg-config \
        protobuf-compiler-grpc \
        python3-dev \
        python3-pip \
        python3-venv \
        rapidjson-dev \
        rsync \
        tzdata \
        zlib1g-dev

[pitrou]

fair enough, we probably have a bunch of dependencies on several docker images that are not required anymore and patch isn't going to be the problematic one:

I've tried trimming some of them in #49032 but it turns out that most of them are probably necessary.

[kou]

+1