Extract shared model I/O name-discovery helpers into CoreAIShared - #177
Merged
Conversation
Move findImageInputName, findLogitsOutputName, and findBoxesOutputName into a new ModelIONameResolver enum in CoreAIShared/Runtime, eliminating duplication between ObjectDetector and ImageSegmentationEngine.
stikves
requested review from
alejandro-isaza,
carinapeng,
kevchengcodes and
tjia1818
August 17, 2026 16:45
tjia1818
approved these changes
Aug 17, 2026
kevchengcodes
approved these changes
Aug 17, 2026
kevchengcodes
left a comment
kevchengcodes
left a comment
Contributor
There was a problem hiding this comment.
thanks for making this shared file!
1 task
stikves
added a commit
to stikves/coreai-models
that referenced
this pull request
Aug 17, 2026
findImageInputName and findLogitsOutputName moved to ModelIONameResolver in CoreAIShared — update test references.
stikves
added a commit
to stikves/coreai-models
that referenced
this pull request
Aug 17, 2026
findImageInputName and findLogitsOutputName moved to ModelIONameResolver in CoreAIShared — update test references.
stikves
added a commit
to stikves/coreai-models
that referenced
this pull request
Aug 18, 2026
findImageInputName and findLogitsOutputName moved to ModelIONameResolver in CoreAIShared — update test references.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move findImageInputName, findLogitsOutputName, and findBoxesOutputName into a new ModelIONameResolver enum in CoreAIShared/Runtime, eliminating duplication between ObjectDetector and ImageSegmentationEngine.