Repository navigation
Remove third-party CRDs from charts; add crd-manager - #1358
Merged
Merged
Conversation
ArnobKumarSaha
force-pushed
the
arnob-crd-manager
branch
5 times, most recently
from
October 2, 2026 05:20
3c795d2 to
90fc848
Compare
ArnobKumarSaha
force-pushed
the
arnob-crd-manager
branch
3 times, most recently
from
October 2, 2026 06:48
87bb691 to
c7401c7
Compare
Third-party CRD copies (cert-manager, ServiceMonitor, Gateway API, Envoy Gateway, Flux) are dropped from chart crds/ dirs. Objects of those kinds are now gated on .Capabilities.APIVersions.Has. A new crd-manager chart, deployed by ace-installer before opscenter-features, creates the missing CRDs without overwriting vendor-managed copies. Signed-off-by: Arnob Kumar Saha <arnob@appscode.com>
ArnobKumarSaha
force-pushed
the
arnob-crd-manager
branch
from
October 2, 2026 07:16
c7401c7 to
953bd40
Compare
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Charts no longer bundle copies of third-party CRDs. Under Flux
CreateReplace, those copies overwrote vendor-managed CRDs (OpenShift, GKE, NKP, …).Removed CRD copies
ace-installer: FluxHelmRelease,HelmRepository(Flux is a prerequisite)opscenter-features: FluxHelmRepositorycatalog-manager:EnvoyProxy(never rendered)license-proxyserver:ServiceMonitorservice-gateway: cert-managerCertificate/Issuer/ClusterIssuer,EnvoyProxy, Gateway APIGatewayClass/Gateway/HTTPRouteimport-crds.shno longer imports them.Capabilities gating
license-proxyserverServiceMonitor and everyservice-gatewayobject of these kinds now also require.Capabilities.APIVersions.Has "<group>/<version>/<Kind>". When the CRDs are present,helm templateoutput is the same as master (apart from random certs).crd-manager
charts/crd-manager(pre-install/upgrade hook Job, imageghcr.io/appscode/crd-manager), from https://github.com/appscode-cloud/crd-manager.CertManager,EnvoyGateway,GatewayAPI,PrometheusOperator.ace-installerdeploys it as HelmReleasecrd-managerfrom thebootstraprepo, andopscenter-featuresdepends on it, so every other release runs after it.Before merge
make gen(zz_generated.deepcopy.go, crd-managervalues.openapiv3_schema.yaml+ README, ace-installer README)ace-installer-certified{,-crds}with chart-packercrd-managerimagev0.0.1(ct forcharts/crd-managerfails until then)