Skip to content

Migrate light_gizmos to use FeathersRadio and FeathersSlider - #25346

Open
Tatsuya0330 wants to merge 7 commits into
bevyengine:mainfrom
Tatsuya0330:issue_25032_light_gizmos
Open

Migrate light_gizmos to use FeathersRadio and FeathersSlider#25346
Tatsuya0330 wants to merge 7 commits into
bevyengine:mainfrom
Tatsuya0330:issue_25032_light_gizmos

Conversation

@Tatsuya0330

@Tatsuya0330 Tatsuya0330 commented Aug 10, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Objective

Solution

  • Replaced key inputs with FeathersRadio buttons and FeathersSlider.
  • Used the helpers in examples/helpers/radio.rs.

Testing

  • Tested manually using cargo run --example light_gizmos --features="bevy_feathers".

Showcase

light_gizmos.2026-08-12.21-09-43.mp4

Remarks

  • I considered refactoring the slider logic into a helper function, but gave up as abstracting on(slider_update) was difficult.

@Tatsuya0330
Tatsuya0330 marked this pull request as draft August 10, 2026 09:02
@Tatsuya0330
Tatsuya0330 marked this pull request as ready for review August 10, 2026 10:01
@Tatsuya0330
Tatsuya0330 marked this pull request as draft August 10, 2026 12:19
@kristoff3r kristoff3r added D-Trivial Nice and easy! A great choice to get started with Bevy C-Examples An addition or correction to our examples S-Needs-Review Needs reviewer attention (from anyone!) to move forward S-Waiting-on-Author The author needs to make changes or address concerns before this can be merged and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Aug 10, 2026
@Tatsuya0330
Tatsuya0330 marked this pull request as ready for review August 12, 2026 12:24
kfc35
kfc35 reviewed Aug 13, 2026
View reviewed changes
Comment thread examples/gizmos/light_gizmos.rs Outdated
@kfc35
kfc35 self-requested a review August 13, 2026 14:35
@kfc35
kfc35 requested review from taearls and tevans-3 August 13, 2026 14:36
@kfc35 kfc35 added S-Needs-Review Needs reviewer attention (from anyone!) to move forward and removed S-Waiting-on-Author The author needs to make changes or address concerns before this can be merged labels Aug 13, 2026
kfc35
kfc35 reviewed Aug 13, 2026
View reviewed changes
Comment thread examples/gizmos/light_gizmos.rs Outdated
@kfc35 kfc35 added S-Waiting-on-Author The author needs to make changes or address concerns before this can be merged and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Aug 13, 2026
@kfc35 kfc35 added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Waiting-on-Author The author needs to make changes or address concerns before this can be merged labels Aug 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers
@kfc35 kfc35 kfc35 approved these changes
@taearls taearls taearls approved these changes
@tevans-3 tevans-3 tevans-3 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

C-Examples An addition or correction to our examples D-Trivial Nice and easy! A great choice to get started with Bevy S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Tatsuya0330 @kfc35 @taearls @tevans-3 @kristoff3r