Remove redundant initialization in Table::allocate - #25353
Open
JaySpruce wants to merge 4 commits into
Open
Conversation
chescock
approved these changes
Aug 10, 2026
mockersf
approved these changes
Aug 13, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to a conflict with the base branch
Aug 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Table::allocatezero-initializes ticks immediately after reserving a new row in its columns, but this isn't really necessary since eitherColumn::initialize_from_unchecked(inTables::move_row) orColumn::initialize(inBundleInfo::write_components) is always called before they're assumed to be initialized.Solution
Remove the initialization in
Table::allocate(and updateColumn::initializeto expect to actually initialize them).Testing
Pretty good:
