Fix wireframe specialization - #25376
Open
blaind wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Fixes #25375
Solution
When msaa changes, bevy detects the view key as changed. Existing code sets only
DirtySpecializationsas dirty, but leavesDirtyWireframeSpecializationsuntouched. This patch adds the dirty flag to the latter as well.Testing
To test the before-after behavior, please apply the patch at #25375 to the bevy wireframe example.
Before this patch: error logs + crash
After this patch: continues working
Tested both 3d & 2d.
2D repro
AI disclosure: the root cause analysis, patch & test code for 2D was written by AI.