Refactor Bevy_Picking to use MouseButton instead of PointerButton. - #25417
Closed
codecnotsupported wants to merge 2 commits into
Closed
Refactor Bevy_Picking to use MouseButton instead of PointerButton.#25417codecnotsupported wants to merge 2 commits into
codecnotsupported wants to merge 2 commits into
Conversation
codecnotsupported
force-pushed
the
refactor
branch
from
August 15, 2026 13:27
71e570e to
ed17368
Compare
Contributor
|
Hi! Can you explain why you are proposing this? The pointer button decomposition is intensional, since it allows for virtual pointers. |
Contributor
Author
See #25392
Could you clarify what you mean? |
Member
|
Closing this as Pointer is general purpose abstraction, which includes other types of non-mouse pointers like "touch input" and "virtual pointers" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Redid #25392 PR due to merge conflicts with #25337.
Also cleaned up the commits fixed the migration guide, should be easier to read.