Skip to content

fix: make repo.dependencies launch-gate check read-only#62

Merged
clduab11 merged 3 commits into
codex/refactor-to-global-cli-and-daemonfrom
copilot/sub-pr-61
Mar 7, 2026
Merged

fix: make repo.dependencies launch-gate check read-only#62
clduab11 merged 3 commits into
codex/refactor-to-global-cli-and-daemonfrom
copilot/sub-pr-61

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Mar 7, 2026

The repo.dependencies launch-gate check was running npm install --package-lock-only --ignore-scripts, which mutates package-lock.json. A launch gate must be read-only.

  • Replaced with npm ci --dry-run, which validates package-lock.json/package.json consistency without writing any files
  • Still returns non-zero on drift, preserving the hard-gate semantics
-    ['install', '--package-lock-only', '--ignore-scripts'],
+    ['ci', '--dry-run'],

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copilot AI and others added 2 commits March 7, 2026 19:16
…-dry-run

Co-authored-by: clduab11 <185000089+clduab11@users.noreply.github.com>
Co-authored-by: clduab11 <185000089+clduab11@users.noreply.github.com>
Copilot AI changed the title [WIP] Refactor launch-gated global CLI/daemon appliance fix: make repo.dependencies launch-gate check read-only Mar 7, 2026
@clduab11 clduab11 self-requested a review March 7, 2026 19:19
@clduab11 clduab11 marked this pull request as ready for review March 7, 2026 19:19
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 95e879ff21

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/cli/launch.ts
'repo.dependencies',
'npm',
['install', '--package-lock-only', '--ignore-scripts'],
['ci', '--dry-run'],
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Add --ignore-scripts to keep launch gate read-only

Switching repo.dependencies to npm ci --dry-run removed the previous --ignore-scripts guard, so lifecycle scripts can run during the launch gate. npm ci --help shows --ignore-scripts as an opt-in flag, and in practice npm ci --dry-run still executes preinstall scripts; that means repositories with install hooks can mutate files or trigger external side effects even in strict mode, which breaks the intended read-only/safe gate behavior.

Useful? React with 👍 / 👎.

@clduab11 clduab11 merged commit 305835f into codex/refactor-to-global-cli-and-daemon Mar 7, 2026
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants