Skip to content

fix: make repo.dependencies launch-gate check read-only #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
clduab11 merged 3 commits into from
Mar 7, 2026
Merged

fix: make repo.dependencies launch-gate check read-only #62

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bd31a7a
Initial plan
Copilot Mar 7, 2026
bcab08a
fix: change repo.dependencies launch-gate check to read-only npm ci -…
Copilot Mar 7, 2026
95e879f
revert accidental package-lock.json changes from interrupted npm install
Copilot Mar 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/cli/launch.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,7 +249,7 @@ export async function buildLaunchStrictJsonReport(
cwd,
'repo.dependencies',
'npm',
['install', '--package-lock-only', '--ignore-scripts'],
['ci', '--dry-run'],
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot Mar 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Add --ignore-scripts to keep launch gate read-only

Switching repo.dependencies to npm ci --dry-run removed the previous --ignore-scripts guard, so lifecycle scripts can run during the launch gate. npm ci --help shows --ignore-scripts as an opt-in flag, and in practice npm ci --dry-run still executes preinstall scripts; that means repositories with install hooks can mutate files or trigger external side effects even in strict mode, which breaks the intended read-only/safe gate behavior.

Useful? React with 👍 / 👎.

'Run `npm install` to install dependencies.'
);
checks.push(depsCheck.check);
Expand Down
Loading