fix(alerts): exclude erofs/squashfs from KubernetesNodeReadOnlyRootFilesystem alert - #50
Merged
ibakshay merged 3 commits intoAug 21, 2026
Conversation
erofs and squashfs filesystems are read-only by design (e.g. Garden Linux uses erofs on /dev/loop0 mounted at /). The previous rule matched these, causing false-positive alerts on healthy nodes. Observed on node001-bb629 in cc-b0-eu-de-1: /dev/loop0 (erofs) fires the alert even though the node is fully operational. Signed-off-by: jeoffzheng <101314942+jeoffzheng@users.noreply.github.com>
Signed-off-by: jeoffzheng <101314942+jeoffzheng@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adjusts the KubernetesNodeReadOnlyRootFilesystem Prometheus alert to avoid false positives on Garden Linux nodes where the root filesystem can be read-only by design (e.g., erofs), and bumps the Helm chart/plugin versions for release.
Changes:
- Excludes read-only-by-design filesystem types (
erofs,squashfs,iso9660) from the root filesystem read-only alert expression. - Bumps Helm chart version from
1.3.1to1.3.2. - Updates the plugin definition to reference version
1.3.2.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| charts/kubernetes-operations/alerts/kubernetes-node.yaml | Updates alert PromQL to exclude specific read-only-by-design fstypes. |
| charts/kubernetes-operations/Chart.yaml | Bumps chart version to 1.3.2. |
| charts/kubernetes-operations/plugindefinition.yaml | Updates plugin and referenced chart version to 1.3.2. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Signed-off-by: jeoffzheng <101314942+jeoffzheng@users.noreply.github.com>
Contributor
Author
|
@viennaa would you mind to review it again? thanks. |
Contributor
Author
|
@viennaa mmm, not sure why, but i can not merge it ( no merge button appear for me), would you mind to merge it? thx |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
during the recently KVM upgrade, we observed that the
KubernetesNodeReadOnlyRootFilesystemalert fires false positives becauseerofsfilesystems are read-only by design