Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Checks/PWR043/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,7 @@ end do

* [PWR043 examples](https://github.com/codee-com/open-catalog/tree/main/Checks/PWR043/)

* [PWR010: Avoid column-major array access in C/C++](../PWR010/README.md)
* [PWR010: Avoid column-major array access in C/C++](../../Deprecated/PWR010/README.md)

* [PWR039: Consider loop interchange to improve the locality of reference and enable vectorization](../PWR039/README.md)

Expand Down
2 changes: 1 addition & 1 deletion Checks/PWR062/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,7 @@ end subroutine matmul

* [PWR062 examples](https://github.com/codee-com/open-catalog/tree/main/Checks/PWR062/)

* [PWR010: Avoid column-major array access in C/C++](../PWR010/README.md)
* [PWR010: Avoid column-major array access in C/C++](../../Deprecated/PWR010/README.md)

* [PWR039: Consider loop interchange to improve the locality of reference and enable vectorization](../PWR039/README.md)

Expand Down
3 changes: 3 additions & 0 deletions Checks/_category_.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
{
"position": 2
}
11 changes: 10 additions & 1 deletion Checks/PWR010/README.md → Deprecated/PWR010/README.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,14 @@
# PWR010: Avoid column-major array access in C/C++

> [!WARNING]
> This check was deprecated in favor of [PWR039](../../Checks/PWR039/README.md)
> and [PWR040](../../Checks/PWR040/README.md). This is because PWR010 can apply
> to loops with multiple array accesses. When the stride is fixed, applying it
> may break the other accesses, creating a conflicting situation. In contrast,
> [PWR039](../../Checks/PWR039/README.md) and
> [PWR040](../../Checks/PWR040/README.md) only apply when all accesses are
> inefficient, which makes the check safe and actionable.

### Issue

In the C and C++ programming languages, matrices are stored in a
Expand Down Expand Up @@ -55,7 +64,7 @@ for (int i = 0; i < n; ++i) {

### Related resources

* [PWR010 examples](https://github.com/codee-com/open-catalog/tree/main/Checks/PWR010/)
* [PWR010 examples](https://github.com/codee-com/open-catalog/tree/main/Deprecated/PWR010/)

### References

Expand Down
File renamed without changes.
9 changes: 8 additions & 1 deletion Checks/PWR033/README.md → Deprecated/PWR033/README.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,12 @@
# PWR033: Move invariant conditional out of the loop to avoid redundant computations

> [!WARNING]
> This check was deprecated in favor of [PWR022](../../Checks/PWR022/README.md).
> This is because PWR033 largely overlaps with
> [PWR022](../../Checks/PWR022/README.md), but
> [PWR022](../../Checks/PWR022/README.md) provides clearer actionable guidance
> and better examples.

### Issue

[Loop-invariant conditional](../../Glossary/Loop-unswitching.md) can be moved out of
Expand Down Expand Up @@ -103,7 +110,7 @@ end subroutine

### Related resources

* [PWR033 examples](https://github.com/codee-com/open-catalog/tree/main/Checks/PWR033/)
* [PWR033 examples](https://github.com/codee-com/open-catalog/tree/main/Deprecated/PWR033/)

### References

Expand Down
File renamed without changes.
File renamed without changes.
9 changes: 9 additions & 0 deletions Checks/RMK001/README.md → Deprecated/RMK001/README.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,14 @@
# RMK001: loop nesting that might benefit from hybrid parallelization using multithreading and SIMD

> [!WARNING]
> This check was deprecated in favor of [PWR050](../../Checks/PWR050/README.md),
> [PWR051](../../Checks/PWR051/README.md),
> [PWR052](../../Checks/PWR052/README.md),
> [PWR053](../../Checks/PWR053/README.md), and
> [PWR054](../../Checks/PWR054/README.md). This is because RMK001 combined
> multithreading and vectorization concerns into a single check. The highlighted
> checks split these cases into more focused and actionable rules.

### Issue

Use multi-threading and SIMD hybrid parallelization to maximize the parallel
Expand Down
9 changes: 9 additions & 0 deletions Checks/RMK002/README.md → Deprecated/RMK002/README.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,14 @@
# RMK002: Loop nesting that might benefit from hybrid parallelization using offloading and SIMD

> [!WARNING]
> This check was deprecated in favor of [PWR053](../../Checks/PWR053/README.md),
> [PWR054](../../Checks/PWR054/README.md),
> [PWR055](../../Checks/PWR055/README.md),
> [PWR056](../../Checks/PWR056/README.md), and
> [PWR057](../../Checks/PWR057/README.md). This is because RMK002 combined
> offloading and vectorization concerns into a single check. The highlighted
> checks split these cases into more focused and actionable rules.

### Issue

Use offloading to the GPU and SIMD hybrid parallelization to maximize the
Expand Down
3 changes: 3 additions & 0 deletions Checks/RMK003/README.md → Deprecated/RMK003/README.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
# RMK003: potential temporary variable for the loop which might be privatizable, thus enabling the loop parallelization

> [!WARNING]
> This check was deprecated due to the lack of actionable guidance and examples.

### Issue

Loop is a potential parallelization opportunity if it can be confirmed that
Expand Down
9 changes: 9 additions & 0 deletions Checks/RMK007/README.md → Deprecated/RMK007/README.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,14 @@
# RMK007: Vectorization opportunity within a multithreaded region

> [!WARNING]
> This check was deprecated in favor of [PWR050](../../Checks/PWR050/README.md),
> [PWR051](../../Checks/PWR051/README.md),
> [PWR052](../../Checks/PWR052/README.md),
> [PWR053](../../Checks/PWR053/README.md), and
> [PWR054](../../Checks/PWR054/README.md). This is because RMK007 combined
> multithreading and vectorization concerns into a single check. The highlighted
> checks split these cases into more focused and actionable rules.

### Issue

There is a SIMD vectorization opportunity within a multithreaded region.
Expand Down
9 changes: 9 additions & 0 deletions Checks/RMK008/README.md → Deprecated/RMK008/README.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,14 @@
# RMK008: Vectorization opportunity within an offloaded region

> [!WARNING]
> This check was deprecated in favor of [PWR053](../../Checks/PWR053/README.md),
> [PWR054](../../Checks/PWR054/README.md),
> [PWR055](../../Checks/PWR055/README.md),
> [PWR056](../../Checks/PWR056/README.md), and
> [PWR057](../../Checks/PWR057/README.md). This is because RMK008 combined
> offloading and vectorization concerns into a single check. The highlighted
> checks split these cases into more focused and actionable rules.

### Issue

There is a SIMD vectorization opportunity within an offloaded region.
Expand Down
3 changes: 3 additions & 0 deletions Checks/RMK009/README.md → Deprecated/RMK009/README.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
# RMK009: Outline loop to increase compiler and tooling code coverage

> [!WARNING]
> This check was deprecated due to the lack of actionable guidance and examples.

We are working on this remark and it will be available soon.
3 changes: 3 additions & 0 deletions Deprecated/_category_.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
{
"position": 4
}
3 changes: 3 additions & 0 deletions Glossary/_category_.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
{
"position": 3
}
Loading