refactor: split header-only drivers into source + header files#2373
Open
kira-autonoma wants to merge 1 commit intocommaai:masterfrom
Open
refactor: split header-only drivers into source + header files#2373kira-autonoma wants to merge 1 commit intocommaai:masterfrom
kira-autonoma wants to merge 1 commit intocommaai:masterfrom
Conversation
Move function implementations from .h files into corresponding .c files, keeping only declarations, macros, and type definitions in headers. Affected: all board/drivers/*.h and board/sys/*.h files. No functional changes — pure structural refactor. Closes commaai#2171
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refactors the board drivers from all-header style to proper source + header file structure:
.hfiles into corresponding.cfilesstatic inlinefunctionsFiles Changed
board/drivers/*.h→ declarations onlyboard/drivers/*.c→ new implementation filesboard/sys/*.h→ declarations onlyboard/sys/*.c→ new implementation filesCloses #2171