Repository navigation
Conversation
Install the full agent-config file set (CLAUDE.md, AGENTS.md, copilot-instructions.md, and .claude/*.md) tailored to this skill package: Ruby Vagrantfile + Bash scripts, bats-core tests, the Agent Skills standard, and the make lint/test workflow. Folds the existing skill-specific CLAUDE.md guidance into the template structure. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR replaces the prior single Claude-focused guidance with a multi-agent configuration set for Claude, Codex-compatible agents, and Copilot, documenting repository workflow, stack, language, architecture, source control, and decision logging expectations.
Changes:
- Reworked
CLAUDE.mdas the top-level Claude guidance with repo-specific rules and include chain. - Added
AGENTS.mdand.github/copilot-instructions.mdfor Codex-compatible agents and Copilot. - Added granular
.claude/*.mdfiles covering workflow, stack, source control, language conventions, history logging, and architecture.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
CLAUDE.md |
Updates Claude entry-point guidance and links to .claude/workflow.md. |
AGENTS.md |
Adds Codex-compatible agent instructions and repo layout guidance. |
.github/copilot-instructions.md |
Adds Copilot-specific project, stack, workflow, and DoD guidance. |
.claude/workflow.md |
Defines planning, execution, intake, model validation, and DoD. |
.claude/stack.md |
Documents confirmed skill format, tooling, VM contents, packaging, and exclusions. |
.claude/sourcecontrol.md |
Documents branch, commit, PR, worktree, destructive operation, and release practices. |
.claude/language.md |
Documents Bash, Ruby, skill definition, and bats testing conventions. |
.claude/history.md |
Defines JSONL decision and reference logging formats. |
.claude/architecture.md |
Documents the skill’s architecture boundaries and anti-patterns. |
Comments suppressed due to low confidence (1)
.github/copilot-instructions.md:65
- This Definition of Done points contributors at a validation command that does not include the required
vagrantdirectory-name workaround used in CI. Running it from the repo root can fail despite valid content, so this should reference the CI-equivalent temp-directory validation command or a make target that wraps it.
- Skill changes validate (`npx --yes skills-ref validate`).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| ## Definition of Done | ||
| A task is done only when: | ||
| - [ ] Lint and unit tests pass: `make lint && make test` (matches CI: shellcheck + `ruby -c` + bats unit suites). When a Vagrant provider is available and VM behavior changed, also run `make test-integration` (or `make test-all`). | ||
| - [ ] Skill changes validate against the Agent Skills standard: `npx --yes skills-ref validate` (CI runs this as `validate-skill`). |
| --- | ||
|
|
||
| ## Skill Definition (Markdown + YAML frontmatter) | ||
| - `SKILL.md` is validated against the Agent Skills standard via `npx --yes skills-ref validate` (CI `validate-skill` job). |
|
|
||
| ## Skill Format | ||
| - Agent Skills standard: `SKILL.md` with YAML frontmatter (`name`, `description`, `license`, `compatibility`, `allowed-tools`, `metadata`). | ||
| - Validated with `npx --yes skills-ref validate` (CI job `validate-skill`; validator requires the skill dir to be named `vagrant`). |
| --- | ||
|
|
||
| ## Stack | ||
| - Skill format: Agent Skills standard (`SKILL.md` with YAML frontmatter); validated via `npx skills-ref validate`. |
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Contributor
Author
|
Superseded by a fresh combined PR (agent config + Copilot feedback addressed) so Copilot re-reviews. Branch retained. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The repo had a single ad-hoc
CLAUDE.mdand no shared, multi-agent instruction set. Codex (AGENTS.md), Copilot (.github/copilot-instructions.md), and the granular.claude/*.mdcontext files were missing, so agent guidance was inconsistent and not self-contained per tool.Approach
Applied the agent-config template from
jp/cfixand filled every placeholder with values verified from this repo:SKILL.md,Vagrantfile,Makefile,package.json,scripts/setup.sh+verify.sh,test/*.bats,references/,examples/,.github/workflows/ci.yml, existingCLAUDE.md, and GitHub Issues.CLAUDE.md: kept operator prefs + guardrails +@.claude/workflow.mdinclude chain; folded in the existing skill-specific guidance (key commands, file layout, idempotency/shellcheck rules) rather than dropping it.language.md: kept only real languages — Bash (shellcheck) and Ruby (ruby -c, Ruby 3.3 in CI); validation via bats-core (no coverage tooling). Dropped Go/TS/Python/.NET blocks.stack.md: documented the Agent Skills format +skills-refvalidator, contributor toolchain, provisioned-VM contents, and npm/ClawHub packaging; omitted persistence/messaging/auth/observability/cloud (N/A).architecture.md: trimmed to the skill's real contracts (general-purpose, idempotent, disposable, multi-provider); marked service-oriented sections N/A.workflow.md: DoD test command set tomake lint && make test(matches CI), withmake test-integration/make test-allfor provider-backed runs; Work Intake = GitHub Issues (verified active).sourcecontrol.md:github.com/daax-dev/vagrant-skill, defaultmain, semver/bump-branch release flow.Detected stack
Agent Skill package (Agent Skills standard). Ruby
Vagrantfile(multi-provider: Parallels/libvirt/VirtualBox,bento/ubuntu-24.04); Bash provisioning scripts; bats-core tests; npm package@daax-dev/vagrant-skill(Node >=22.14.0) published to npm + ClawHub; GitHub Actions CI (lint -> test + validate-skill).Test evidence
Docs/config-only change. Referenced files verified to exist; no stray
[FILL IN]placeholders remain.make lintpasses (shellcheck +ruby -c Vagrantfile-> Syntax OK);make testpasses (63/63 bats unit tests).Validation
Producer: Claude Opus 4.7. Validator: self-review (cross-provider Claude <-> Codex not available in this environment).