Repository navigation
Conversation
Install the full agent-config file set (CLAUDE.md, AGENTS.md, copilot-instructions.md, and .claude/*.md) tailored to this skill package: Ruby Vagrantfile + Bash scripts, bats-core tests, the Agent Skills standard, and the make lint/test workflow. Folds the existing skill-specific CLAUDE.md guidance into the template structure. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Introduces a multi-agent instruction set for this repository so different AI tools (Claude, Codex-compatible agents, and GitHub Copilot) get consistent, repo-specific guidance aligned with the existing CI/skill workflow.
Changes:
- Reworked
CLAUDE.mdinto a Claude entry point that delegates detailed guidance to.claude/*.mddocuments. - Added
AGENTS.mdand.github/copilot-instructions.mdto provide equivalent guidance for Codex-compatible agents and GitHub Copilot. - Added a structured
.claude/instruction set covering workflow, stack, language conventions, source control, architecture boundaries, and decision/reference logging.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
CLAUDE.md |
Replaces the prior single-file guidance with a structured Claude entry point and .claude/* include chain. |
AGENTS.md |
Adds a Codex-compatible agent entry point mirroring core repo rules and layout. |
.github/copilot-instructions.md |
Adds repo instructions for GitHub Copilot including stack, conventions, and DoD. |
.claude/workflow.md |
Defines planning/execution discipline and DoD for agent-driven work. |
.claude/stack.md |
Documents the confirmed toolchain/runtime/packaging and validation flow for this skill repo. |
.claude/sourcecontrol.md |
Documents branch/commit/PR/release workflow expectations for contributors and agents. |
.claude/language.md |
Records language-specific lint/test expectations (Bash, Ruby/Vagrantfile, skills validation). |
.claude/history.md |
Establishes a JSONL format for decision and reference logs under .logs/. |
.claude/architecture.md |
Captures the repo’s “skill package” architecture boundaries and anti-patterns. |
Comments suppressed due to low confidence (1)
.github/copilot-instructions.md:66
- Same issue as earlier in this file: this snippet omits
|| trueaftercp, but CI includes it to avoid failing when./.*expands to./..(see.github/workflows/ci.yml). Align the documented command with CI to keep the DoD step copy/paste-safe.
A task is done only when:
- `make lint && make test` pass (matching CI). Run `make test-integration` / `make test-all` locally when a provider is available and VM behavior changed.
- Skill changes validate via the CI flow (validator requires the dir named `vagrant`): `mkdir -p /tmp/vagrant && cp -r ./* ./.* /tmp/vagrant/ 2>/dev/null; npx --yes skills-ref validate /tmp/vagrant`.
- PR opened with problem statement, approach, and test evidence.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| ## Definition of Done | ||
| A task is done only when: | ||
| - [ ] Lint and unit tests pass: `make lint && make test` (matches CI: shellcheck + `ruby -c` + bats unit suites). When a Vagrant provider is available and VM behavior changed, also run `make test-integration` (or `make test-all`). | ||
| - [ ] Skill changes validate against the Agent Skills standard. The validator requires the skill directory to be named `vagrant`, so run the CI flow (the `validate-skill` job) rather than invoking it from the `vagrant-skill` checkout root: `mkdir -p /tmp/vagrant && cp -r ./* ./.* /tmp/vagrant/ 2>/dev/null; npx --yes skills-ref validate /tmp/vagrant`. |
|
|
||
| ## Skill Format | ||
| - Agent Skills standard: `SKILL.md` with YAML frontmatter (`name`, `description`, `license`, `compatibility`, `allowed-tools`, `metadata`). | ||
| - Validated by the `validate-skill` CI job. The validator requires the skill dir to be named `vagrant`, so CI copies the checkout to `/tmp/vagrant` before validating: `mkdir -p /tmp/vagrant && cp -r ./* ./.* /tmp/vagrant/ 2>/dev/null; npx --yes skills-ref validate /tmp/vagrant`. |
| --- | ||
|
|
||
| ## Skill Definition (Markdown + YAML frontmatter) | ||
| - `SKILL.md` is validated against the Agent Skills standard. The validator requires the skill directory to be named `vagrant`, so the `validate-skill` CI job copies the checkout to `/tmp/vagrant` first: `mkdir -p /tmp/vagrant && cp -r ./* ./.* /tmp/vagrant/ 2>/dev/null; npx --yes skills-ref validate /tmp/vagrant`. Running it directly from the `vagrant-skill` checkout fails on the directory-name check. |
Comment on lines
+30
to
+33
| ## Stack | ||
| - Skill format: Agent Skills standard (`SKILL.md` with YAML frontmatter); validated by the `validate-skill` CI job. The validator requires the skill directory to be named `vagrant`, so CI copies the checkout to `/tmp/vagrant` first: `mkdir -p /tmp/vagrant && cp -r ./* ./.* /tmp/vagrant/ 2>/dev/null; npx --yes skills-ref validate /tmp/vagrant`. | ||
| - VM tooling: Vagrant CLI with a provider (Parallels / libvirt / VirtualBox). Base box `bento/ubuntu-24.04`. | ||
| - Languages: Ruby (Vagrantfile, syntax-checked with `ruby -c`; Ruby 3.3 in CI) and Bash (`scripts/*.sh`, shellcheck-linted). |
| - `make lint && make test` pass (matching CI). Run `make test-integration` / `make test-all` locally when a provider is available and VM behavior changed. | ||
| - Skill changes validate via the CI flow (validator requires the dir named `vagrant`): `mkdir -p /tmp/vagrant && cp -r ./* ./.* /tmp/vagrant/ 2>/dev/null; npx --yes skills-ref validate /tmp/vagrant`. | ||
| - PR opened with problem statement, approach, and test evidence. | ||
| - No `[FILL IN]` placeholders left in affected files. |
Align documented skill-validation copy command with CI (add `|| true` after cp so it is safe under set -e) across .claude/workflow.md, .claude/stack.md, .claude/language.md, and .github/copilot-instructions.md. Reword the DoD FILL IN bullet so the intentional marker definitions in .claude/stack.md and .claude/language.md no longer violate it. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Contributor
Author
|
Superseded by a fresh PR on the same branch so Copilot re-reviews. Branch retained. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces single Claude-focused guidance with a multi-agent configuration set covering Claude, Codex-compatible agents, and Copilot:
CLAUDE.md— top-level Claude entry point with repo-specific rules and.claude/*include chain.AGENTS.md+.github/copilot-instructions.md— Codex-compatible and Copilot guidance..claude/*.md— workflow, stack, source control, language conventions, history logging, architecture.Addressed Copilot feedback from #22 (4 comments)
All four comments flagged the same accurate issue: the
skills-ref validatecommand needs the CI directory-name workaround (validator requires the skill dir namedvagrant, but the checkout isvagrant-skill). Each now references the CIvalidate-skilltemp-directory flow (mkdir -p /tmp/vagrant && cp -r ./* ./.* /tmp/vagrant/ 2>/dev/null; npx --yes skills-ref validate /tmp/vagrant):.claude/workflow.md:48.claude/language.md:38.claude/stack.md:14.github/copilot-instructions.md:31(also fixed the same issue on line 65, the suppressed low-confidence comment)Verified against
.github/workflows/ci.yml. Skill payload/source untouched.Validation: producer Claude Opus 4.7 / self-review.