Skip to content

Fix when-all buggy error handling#978

Merged
sicoyle merged 2 commits intodapr:mainfrom
acroca:fix-when-all
Apr 14, 2026
Merged

Fix when-all buggy error handling#978
sicoyle merged 2 commits intodapr:mainfrom
acroca:fix-when-all

Conversation

@acroca
Copy link
Copy Markdown
Member

@acroca acroca commented Apr 14, 2026

when using a when_all and one of the tasks fail, the resulting task sometimes failed, sometimes didn't.

@acroca acroca requested review from a team as code owners April 14, 2026 07:58
Signed-off-by: Albert Callarisa <albert@diagrid.io>
@acroca acroca mentioned this pull request Apr 14, 2026
Copy link
Copy Markdown
Contributor

@sicoyle sicoyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!!

@acroca acroca added the automerge allows dapr bot to merge a PR after tests pass label Apr 14, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 14, 2026

Codecov Report

❌ Patch coverage is 95.55556% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.46%. Comparing base (bffb749) to head (2fac29d).
⚠️ Report is 102 commits behind head on main.

Files with missing lines Patch % Lines
...w/tests/durabletask/test_orchestration_executor.py 91.30% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #978      +/-   ##
==========================================
- Coverage   86.63%   80.46%   -6.17%     
==========================================
  Files          84      136      +52     
  Lines        4473    12678    +8205     
==========================================
+ Hits         3875    10201    +6326     
- Misses        598     2477    +1879     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@acroca acroca removed the automerge allows dapr bot to merge a PR after tests pass label Apr 14, 2026
@sicoyle sicoyle added this pull request to the merge queue Apr 14, 2026
Merged via the queue into dapr:main with commit 28a1538 Apr 14, 2026
15 of 16 checks passed
@acroca acroca deleted the fix-when-all branch April 14, 2026 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants