chore(remote_write): temporarily disable pp_protocol websocket/refill endpoints - #492
Merged
Conversation
vporoshok
reviewed
Sep 4, 2026
vporoshok
approved these changes
Sep 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Disables the pp_protocol WebSocket and refill endpoints on the remote-write receiver: both handlers (
remoteWriteWebsocket,remoteWriteRefill) now unconditionally return404 Not Foundinstead of delegating toapi.opHandler. The previous logic is left commented out with a "temporarily disabled pending further development" note for easy rollback once the protocol is ready.What changed
web/api/v1/pp_api.go:remoteWriteWebsocketandremoteWriteRefillno longer checkapi.opHandleror callWebsocket/Refill— they immediately writehttp.Error(..., http.StatusNotFound)with an explicit "not supported" message.Why
pp_protocol(the custom websocket/refill transport for remote-write) needs further work and is being disabled temporarily so the unfinished functionality isn't exposed in production.