Skip to content

chore(remote_write): temporarily disable pp_protocol websocket/refill endpoints #492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
u-veles-a merged 5 commits into from
Sep 4, 2026
Merged

chore(remote_write): temporarily disable pp_protocol websocket/refill endpoints #492

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8f3a470
disabling pp_protocol on remote_write
u-veles-a Aug 26, 2026
62b45f8
Merge branch 'pp' into disabling_pp_protocol
u-veles-a Sep 2, 2026
627791d
description
u-veles-a Sep 2, 2026
bf6b1c7
Merge branch 'pp' into disabling_pp_protocol
u-veles-a Sep 4, 2026
e18cae7
fix(api): review
u-veles-a Sep 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 20 additions & 12 deletions web/api/v1/pp_api.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,22 +140,30 @@ func (api *API) opRemoteWrite(middlewares ...middleware.Middleware) http.Handler
}
}

func (api *API) remoteWriteWebsocket(middlewares ...middleware.Middleware) http.HandlerFunc {
func (api *API) remoteWriteWebsocket(...middleware.Middleware) http.HandlerFunc {
return func(rw http.ResponseWriter, r *http.Request) {
if api.opHandler != nil {
api.opHandler.Websocket(middlewares...).ServeHTTP(rw, r)
} else {
http.Error(rw, "remote write receiver needs to be enabled with --web.enable-remote-write-receiver", http.StatusNotFound)
}
// temporarily disabled pending further development

// if api.opHandler != nil {
// api.opHandler.Websocket(middlewares...).ServeHTTP(rw, r)
// } else {
// http.Error(rw, "remote write receiver needs to be enabled with --web.enable-remote-write-receiver", http.StatusNotFound)
// }

http.Error(rw, "remote write websocket is not supported", http.StatusMethodNotAllowed)
}
}

func (api *API) remoteWriteRefill(middlewares ...middleware.Middleware) http.HandlerFunc {
func (api *API) remoteWriteRefill(...middleware.Middleware) http.HandlerFunc {
return func(rw http.ResponseWriter, r *http.Request) {
if api.opHandler != nil {
api.opHandler.Refill(middlewares...).ServeHTTP(rw, r)
} else {
http.Error(rw, "remote write receiver needs to be enabled with --web.enable-remote-write-receiver", http.StatusNotFound)
}
// temporarily disabled pending further development

// if api.opHandler != nil {
// api.opHandler.Refill(middlewares...).ServeHTTP(rw, r)
// } else {
// http.Error(rw, "remote write receiver needs to be enabled with --web.enable-remote-write-receiver", http.StatusNotFound)
// }

http.Error(rw, "remote write refill is not supported", http.StatusMethodNotAllowed)
}
}
Loading