[main] Source code updates from dotnet/dotnet - #55245
Merged
JanProvaznik merged 9 commits intoJul 14, 2026
Merged
Conversation
Diff: https://github.com/dotnet/dotnet/compare/331fbbd197e21c8ec9d3eef292df8bbcd4deec0d..50dbab4de210e882172b07934e9666313b7065f1 From: dotnet/dotnet@331fbbd To: dotnet/dotnet@50dbab4 [[ commit created by automation ]]
Updated Dependencies: Microsoft.AspNetCore.Analyzers, Microsoft.AspNetCore.App.Ref, Microsoft.AspNetCore.App.Ref.Internal, Microsoft.AspNetCore.Authentication.Facebook, Microsoft.AspNetCore.Authentication.Google, Microsoft.AspNetCore.Authentication.MicrosoftAccount, Microsoft.AspNetCore.Authorization, Microsoft.AspNetCore.Components, Microsoft.AspNetCore.Components.Analyzers, Microsoft.AspNetCore.Components.Forms, Microsoft.AspNetCore.Components.SdkAnalyzers, Microsoft.AspNetCore.Components.Web, Microsoft.AspNetCore.Components.WebAssembly, Microsoft.AspNetCore.Components.WebAssembly.Server, Microsoft.AspNetCore.Components.WebView, Microsoft.AspNetCore.DeveloperCertificates.XPlat, Microsoft.AspNetCore.Metadata, Microsoft.AspNetCore.Mvc.Analyzers, Microsoft.AspNetCore.Mvc.Api.Analyzers, Microsoft.AspNetCore.TestHost, Microsoft.Bcl.AsyncInterfaces, Microsoft.DotNet.Web.ItemTemplates.11.0, Microsoft.DotNet.Web.ProjectTemplates.11.0, Microsoft.Dotnet.WinForms.ProjectTemplates, Microsoft.DotNet.Wpf.ProjectTemplates, Microsoft.Extensions.Configuration.Ini, Microsoft.Extensions.DependencyInjection.Abstractions, Microsoft.Extensions.DependencyModel, Microsoft.Extensions.FileProviders.Abstractions, Microsoft.Extensions.FileProviders.Embedded, Microsoft.Extensions.FileSystemGlobbing, Microsoft.Extensions.Logging, Microsoft.Extensions.Logging.Abstractions, Microsoft.Extensions.Logging.Console, Microsoft.Extensions.ObjectPool, Microsoft.JSInterop, Microsoft.McpServer.ProjectTemplates.11.0, Microsoft.NET.HostModel, Microsoft.NET.ILLink.Tasks, Microsoft.NET.Runtime.Emscripten.5.0.6.Cache.win-x64, Microsoft.NET.Sdk.WindowsDesktop, Microsoft.NETCore.App.Ref, Microsoft.NETCore.Platforms, Microsoft.Win32.SystemEvents, Microsoft.WindowsDesktop.App.Internal, Microsoft.WindowsDesktop.App.Ref, System.CodeDom, System.ComponentModel.Composition, System.Composition.AttributedModel, System.Composition.Convention, System.Composition.Hosting, System.Composition.Runtime, System.Composition.TypedParts, System.Configuration.ConfigurationManager, System.Diagnostics.DiagnosticSource, System.Formats.Asn1, System.IO.Hashing, System.Reflection.MetadataLoadContext, System.Resources.Extensions, System.Security.Cryptography.Pkcs, System.Security.Cryptography.ProtectedData, System.Security.Cryptography.Xml, System.Security.Permissions, System.ServiceProcess.ServiceController, System.Text.Encoding.CodePages, System.Text.Json, System.Windows.Extensions (Version 11.0.0-preview.7.26359.117 -> 11.0.0-preview.7.26360.111) Microsoft.AspNetCore.Mvc.Razor.Extensions.Tooling.Internal, Microsoft.CodeAnalysis.Razor.Tooling.Internal, Microsoft.NET.Sdk.Razor.SourceGenerators.Transport (Version 11.1.0-preview.26359.117 -> 11.1.0-preview.26360.111) Microsoft.Build, Microsoft.Build.Localization, Microsoft.Build.TaskAuthoring.Analyzer (Version 18.10.0-preview-26359-117 -> 18.10.0-1.26360.111) Microsoft.Build.NuGetSdkResolver, NuGet.Build.Tasks, NuGet.Build.Tasks.Console, NuGet.Build.Tasks.Pack, NuGet.CommandLine.XPlat, NuGet.Commands, NuGet.Common, NuGet.Configuration, NuGet.Credentials, NuGet.DependencyResolver.Core, NuGet.Frameworks, NuGet.LibraryModel, NuGet.Localization, NuGet.Packaging, NuGet.ProjectModel, NuGet.Protocol, NuGet.Versioning (Version 7.10.0-rc.36017 -> 7.10.0-rc.36111) Microsoft.Build.Tasks.Git, Microsoft.SourceLink.AzureRepos.Git, Microsoft.SourceLink.Bitbucket.Git, Microsoft.SourceLink.Common, Microsoft.SourceLink.GitHub, Microsoft.SourceLink.GitLab (Version 11.0.100-preview.7.26359.117 -> 11.0.100-preview.7.26360.111) Microsoft.CodeAnalysis, Microsoft.CodeAnalysis.BuildClient, Microsoft.CodeAnalysis.CSharp, Microsoft.CodeAnalysis.CSharp.CodeStyle, Microsoft.CodeAnalysis.CSharp.Features, Microsoft.CodeAnalysis.CSharp.Workspaces, Microsoft.CodeAnalysis.ExternalAccess.HotReload, Microsoft.CodeAnalysis.PublicApiAnalyzers, Microsoft.CodeAnalysis.Workspaces.Common, Microsoft.CodeAnalysis.Workspaces.MSBuild, Microsoft.Net.Compilers.Toolset, Microsoft.Net.Compilers.Toolset.Framework (Version 5.10.0-1.26359.117 -> 5.10.0-1.26360.111) Microsoft.Deployment.DotNet.Releases (Version 2.0.0-preview.1.26359.117 -> 2.0.0-preview.1.26360.111) Microsoft.DiaSymReader, System.CommandLine (Version 3.0.0-preview.7.26359.117 -> 3.0.0-preview.7.26360.111) Microsoft.DotNet.Arcade.Sdk, Microsoft.DotNet.Build.Tasks.Installers, Microsoft.DotNet.Build.Tasks.Templating, Microsoft.DotNet.Build.Tasks.Workloads, Microsoft.DotNet.Helix.JobMonitor, Microsoft.DotNet.Helix.Sdk, Microsoft.DotNet.SignTool, Microsoft.DotNet.XliffTasks, Microsoft.DotNet.XUnitV3Extensions (Version 11.0.0-beta.26359.117 -> 11.0.0-beta.26360.111) Microsoft.FSharp.Compiler (Version 15.2.101-preview7.26359.117 -> 15.2.101-preview7.26360.111) Microsoft.NET.Test.Sdk, Microsoft.TestPlatform.Build, Microsoft.TestPlatform.CLI (Version 18.10.0-preview-26359-117 -> 18.10.0-preview-26360-111) Microsoft.Web.Xdt (Version 3.3.0-preview.7.26359.117 -> 3.3.0-preview.7.26360.111) [[ commit created by automation ]]
Contributor
Author
|
Note VMR PRs included in this codeflow update: 💡 You may consult the FAQ for more information or tag @dotnet/prodconsvcs for assistance. |
Member
Root cause of the
|
Contributor
Author
|
Important While this PR was open, the source repository has received code changes from this repository (an opposite codeflow merged). You can continue with one of the following options:
💡 You may consult the FAQ for more information or tag @dotnet/prodconsvcs for assistance. |
Diff: https://github.com/dotnet/dotnet/compare/458fc4f497a2c9b509d94911b2b4546b80097632..7e07d48faae88ae9068a6afc91e7524b2112c0e7 From: dotnet/dotnet@458fc4f To: dotnet/dotnet@7e07d48 [[ commit created by automation ]]
Updated Dependencies: Microsoft.AspNetCore.Analyzers, Microsoft.AspNetCore.App.Ref, Microsoft.AspNetCore.App.Ref.Internal, Microsoft.AspNetCore.Authentication.Facebook, Microsoft.AspNetCore.Authentication.Google, Microsoft.AspNetCore.Authentication.MicrosoftAccount, Microsoft.AspNetCore.Authorization, Microsoft.AspNetCore.Components, Microsoft.AspNetCore.Components.Analyzers, Microsoft.AspNetCore.Components.Forms, Microsoft.AspNetCore.Components.SdkAnalyzers, Microsoft.AspNetCore.Components.Web, Microsoft.AspNetCore.Components.WebAssembly, Microsoft.AspNetCore.Components.WebAssembly.Server, Microsoft.AspNetCore.Components.WebView, Microsoft.AspNetCore.DeveloperCertificates.XPlat, Microsoft.AspNetCore.Metadata, Microsoft.AspNetCore.Mvc.Analyzers, Microsoft.AspNetCore.Mvc.Api.Analyzers, Microsoft.AspNetCore.TestHost, Microsoft.Bcl.AsyncInterfaces, Microsoft.DotNet.Web.ItemTemplates.11.0, Microsoft.DotNet.Web.ProjectTemplates.11.0, Microsoft.Dotnet.WinForms.ProjectTemplates, Microsoft.DotNet.Wpf.ProjectTemplates, Microsoft.Extensions.Configuration.Ini, Microsoft.Extensions.DependencyInjection.Abstractions, Microsoft.Extensions.DependencyModel, Microsoft.Extensions.FileProviders.Abstractions, Microsoft.Extensions.FileProviders.Embedded, Microsoft.Extensions.FileSystemGlobbing, Microsoft.Extensions.Logging, Microsoft.Extensions.Logging.Abstractions, Microsoft.Extensions.Logging.Console, Microsoft.Extensions.ObjectPool, Microsoft.JSInterop, Microsoft.McpServer.ProjectTemplates.11.0, Microsoft.NET.HostModel, Microsoft.NET.ILLink.Tasks, Microsoft.NET.Sdk.WindowsDesktop, Microsoft.NETCore.App.Ref, Microsoft.NETCore.Platforms, Microsoft.Win32.SystemEvents, Microsoft.WindowsDesktop.App.Internal, Microsoft.WindowsDesktop.App.Ref, System.CodeDom, System.ComponentModel.Composition, System.Composition.AttributedModel, System.Composition.Convention, System.Composition.Hosting, System.Composition.Runtime, System.Composition.TypedParts, System.Configuration.ConfigurationManager, System.Diagnostics.DiagnosticSource, System.Formats.Asn1, System.IO.Hashing, System.Reflection.MetadataLoadContext, System.Resources.Extensions, System.Security.Cryptography.Pkcs, System.Security.Cryptography.ProtectedData, System.Security.Cryptography.Xml, System.Security.Permissions, System.ServiceProcess.ServiceController, System.Text.Encoding.CodePages, System.Text.Json, System.Windows.Extensions (Version 11.0.0-preview.7.26360.111 -> 11.0.0-preview.7.26363.107) Microsoft.AspNetCore.Mvc.Razor.Extensions.Tooling.Internal, Microsoft.CodeAnalysis.Razor.Tooling.Internal, Microsoft.NET.Sdk.Razor.SourceGenerators.Transport (Version 11.1.0-preview.26360.111 -> 11.1.0-preview.26363.107) Microsoft.Build, Microsoft.Build.Localization, Microsoft.Build.TaskAuthoring.Analyzer (Version 18.10.0-1.26360.111 -> 18.10.0-1.26363.107) Microsoft.Build.NuGetSdkResolver, NuGet.Build.Tasks, NuGet.Build.Tasks.Console, NuGet.Build.Tasks.Pack, NuGet.CommandLine.XPlat, NuGet.Commands, NuGet.Common, NuGet.Configuration, NuGet.Credentials, NuGet.DependencyResolver.Core, NuGet.Frameworks, NuGet.LibraryModel, NuGet.Localization, NuGet.Packaging, NuGet.ProjectModel, NuGet.Protocol, NuGet.Versioning (Version 7.10.0-rc.36111 -> 7.10.0-rc.36407) Microsoft.Build.Tasks.Git, Microsoft.SourceLink.AzureRepos.Git, Microsoft.SourceLink.Bitbucket.Git, Microsoft.SourceLink.Common, Microsoft.SourceLink.GitHub, Microsoft.SourceLink.GitLab (Version 11.0.100-preview.7.26360.111 -> 11.0.100-preview.7.26363.107) Microsoft.CodeAnalysis, Microsoft.CodeAnalysis.BuildClient, Microsoft.CodeAnalysis.CSharp, Microsoft.CodeAnalysis.CSharp.CodeStyle, Microsoft.CodeAnalysis.CSharp.Features, Microsoft.CodeAnalysis.CSharp.Workspaces, Microsoft.CodeAnalysis.ExternalAccess.HotReload, Microsoft.CodeAnalysis.PublicApiAnalyzers, Microsoft.CodeAnalysis.Workspaces.Common, Microsoft.CodeAnalysis.Workspaces.MSBuild, Microsoft.Net.Compilers.Toolset, Microsoft.Net.Compilers.Toolset.Framework (Version 5.10.0-1.26360.111 -> 5.10.0-1.26363.107) Microsoft.Deployment.DotNet.Releases (Version 2.0.0-preview.1.26360.111 -> 2.0.0-preview.1.26363.107) Microsoft.DiaSymReader, System.CommandLine (Version 3.0.0-preview.7.26360.111 -> 3.0.0-preview.7.26363.107) Microsoft.DotNet.Arcade.Sdk, Microsoft.DotNet.Build.Tasks.Installers, Microsoft.DotNet.Build.Tasks.Templating, Microsoft.DotNet.Build.Tasks.Workloads, Microsoft.DotNet.Helix.JobMonitor, Microsoft.DotNet.Helix.Sdk, Microsoft.DotNet.SignTool, Microsoft.DotNet.XliffTasks, Microsoft.DotNet.XUnitV3Extensions (Version 11.0.0-beta.26360.111 -> 11.0.0-beta.26363.107) Microsoft.FSharp.Compiler (Version 15.2.101-preview7.26360.111 -> 15.2.101-preview7.26363.107) Microsoft.NET.Test.Sdk, Microsoft.TestPlatform.Build, Microsoft.TestPlatform.CLI (Version 18.10.0-preview-26360-111 -> 18.10.0-preview-26363-107) Microsoft.Web.Xdt (Version 3.3.0-preview.7.26360.111 -> 3.3.0-preview.7.26363.107) [[ commit created by automation ]]
Contributor
Author
|
Note VMR PRs included in this codeflow update:
💡 You may consult the FAQ for more information or tag @dotnet/prodconsvcs for assistance. |
Updated Dependencies: Microsoft.AspNetCore.Analyzers, Microsoft.AspNetCore.App.Ref, Microsoft.AspNetCore.App.Ref.Internal, Microsoft.AspNetCore.Authentication.Facebook, Microsoft.AspNetCore.Authentication.Google, Microsoft.AspNetCore.Authentication.MicrosoftAccount, Microsoft.AspNetCore.Authorization, Microsoft.AspNetCore.Components, Microsoft.AspNetCore.Components.Analyzers, Microsoft.AspNetCore.Components.Forms, Microsoft.AspNetCore.Components.SdkAnalyzers, Microsoft.AspNetCore.Components.Web, Microsoft.AspNetCore.Components.WebAssembly, Microsoft.AspNetCore.Components.WebAssembly.Server, Microsoft.AspNetCore.Components.WebView, Microsoft.AspNetCore.DeveloperCertificates.XPlat, Microsoft.AspNetCore.Metadata, Microsoft.AspNetCore.Mvc.Analyzers, Microsoft.AspNetCore.Mvc.Api.Analyzers, Microsoft.AspNetCore.TestHost, Microsoft.Bcl.AsyncInterfaces, Microsoft.DotNet.Web.ItemTemplates.11.0, Microsoft.DotNet.Web.ProjectTemplates.11.0, Microsoft.Dotnet.WinForms.ProjectTemplates, Microsoft.DotNet.Wpf.ProjectTemplates, Microsoft.Extensions.Configuration.Ini, Microsoft.Extensions.DependencyInjection.Abstractions, Microsoft.Extensions.DependencyModel, Microsoft.Extensions.FileProviders.Abstractions, Microsoft.Extensions.FileProviders.Embedded, Microsoft.Extensions.FileSystemGlobbing, Microsoft.Extensions.Logging, Microsoft.Extensions.Logging.Abstractions, Microsoft.Extensions.Logging.Console, Microsoft.Extensions.ObjectPool, Microsoft.JSInterop, Microsoft.McpServer.ProjectTemplates.11.0, Microsoft.NET.HostModel, Microsoft.NET.ILLink.Tasks, Microsoft.NET.Sdk.WindowsDesktop, Microsoft.NETCore.App.Ref, Microsoft.NETCore.Platforms, Microsoft.Win32.SystemEvents, Microsoft.WindowsDesktop.App.Internal, Microsoft.WindowsDesktop.App.Ref, System.CodeDom, System.ComponentModel.Composition, System.Composition.AttributedModel, System.Composition.Convention, System.Composition.Hosting, System.Composition.Runtime, System.Composition.TypedParts, System.Configuration.ConfigurationManager, System.Diagnostics.DiagnosticSource, System.Formats.Asn1, System.IO.Hashing, System.Reflection.MetadataLoadContext, System.Resources.Extensions, System.Security.Cryptography.Pkcs, System.Security.Cryptography.ProtectedData, System.Security.Cryptography.Xml, System.Security.Permissions, System.ServiceProcess.ServiceController, System.Text.Encoding.CodePages, System.Text.Json, System.Windows.Extensions (Version 11.0.0-preview.7.26363.107 -> 11.0.0-preview.7.26363.117) Microsoft.AspNetCore.Mvc.Razor.Extensions.Tooling.Internal, Microsoft.CodeAnalysis.Razor.Tooling.Internal, Microsoft.NET.Sdk.Razor.SourceGenerators.Transport (Version 11.1.0-preview.26363.107 -> 11.1.0-preview.26363.117) Microsoft.Build, Microsoft.Build.Localization, Microsoft.Build.TaskAuthoring.Analyzer (Version 18.10.0-1.26363.107 -> 18.10.0-1.26363.117) Microsoft.Build.NuGetSdkResolver, NuGet.Build.Tasks, NuGet.Build.Tasks.Console, NuGet.Build.Tasks.Pack, NuGet.CommandLine.XPlat, NuGet.Commands, NuGet.Common, NuGet.Configuration, NuGet.Credentials, NuGet.DependencyResolver.Core, NuGet.Frameworks, NuGet.LibraryModel, NuGet.Localization, NuGet.Packaging, NuGet.ProjectModel, NuGet.Protocol, NuGet.Versioning (Version 7.10.0-rc.36407 -> 7.10.0-rc.36417) Microsoft.Build.Tasks.Git, Microsoft.SourceLink.AzureRepos.Git, Microsoft.SourceLink.Bitbucket.Git, Microsoft.SourceLink.Common, Microsoft.SourceLink.GitHub, Microsoft.SourceLink.GitLab (Version 11.0.100-preview.7.26363.107 -> 11.0.100-preview.7.26363.117) Microsoft.CodeAnalysis, Microsoft.CodeAnalysis.BuildClient, Microsoft.CodeAnalysis.CSharp, Microsoft.CodeAnalysis.CSharp.CodeStyle, Microsoft.CodeAnalysis.CSharp.Features, Microsoft.CodeAnalysis.CSharp.Workspaces, Microsoft.CodeAnalysis.ExternalAccess.HotReload, Microsoft.CodeAnalysis.PublicApiAnalyzers, Microsoft.CodeAnalysis.Workspaces.Common, Microsoft.CodeAnalysis.Workspaces.MSBuild, Microsoft.Net.Compilers.Toolset, Microsoft.Net.Compilers.Toolset.Framework (Version 5.10.0-1.26363.107 -> 5.10.0-1.26363.117) Microsoft.Deployment.DotNet.Releases (Version 2.0.0-preview.1.26363.107 -> 2.0.0-preview.1.26363.117) Microsoft.DiaSymReader, System.CommandLine (Version 3.0.0-preview.7.26363.107 -> 3.0.0-preview.7.26363.117) Microsoft.DotNet.Arcade.Sdk, Microsoft.DotNet.Build.Tasks.Installers, Microsoft.DotNet.Build.Tasks.Templating, Microsoft.DotNet.Build.Tasks.Workloads, Microsoft.DotNet.Helix.JobMonitor, Microsoft.DotNet.Helix.Sdk, Microsoft.DotNet.SignTool, Microsoft.DotNet.XliffTasks, Microsoft.DotNet.XUnitV3Extensions (Version 11.0.0-beta.26363.107 -> 11.0.0-beta.26363.117) Microsoft.FSharp.Compiler (Version 15.2.101-preview7.26363.107 -> 15.2.101-preview7.26363.117) Microsoft.NET.Test.Sdk, Microsoft.TestPlatform.Build, Microsoft.TestPlatform.CLI (Version 18.10.0-preview-26363-107 -> 18.10.0-preview-26363-117) Microsoft.Web.Xdt (Version 3.3.0-preview.7.26363.107 -> 3.3.0-preview.7.26363.117) [[ commit created by automation ]]
Member
Root cause of
|
| Run | Result |
|---|---|
| without the property | Restore succeeds — missing project skipped gracefully |
ExcludeRestorePackageImports=true |
error MSB3202 on the missing project |
Comparing binlogs:
- Both runs log the benign
Skipping project "…TestLibrary.csproj" because it was not foundin NuGet''sSkipNonexistentProjects="true"walk/filter steps. - Only with the property set does
_GenerateRestoreGraphthen invoke_GenerateRestoreGraphProjectEntryon the missingTestLibrary.csproj— a<MSBuild>call that does not setSkipNonexistentProjects→MSB3202.
Once MSBuild''s top-level restore instance shares the same global-property set (ExcludeRestorePackageImports=true) that NuGet''s inner _GenerateRestoreProjectPathWalk requests, that walk executes in the same project instance instead of a separate child instance. The walk''s side-effect item _RestoreProjectPathItems — which contains the raw, unfiltered ProjectReference paths (including the nonexistent project) — then bleeds into _GenerateRestoreGraph''s non-skipping <MSBuild> call. Previously the differing configuration kept that pollution isolated in a separate instance, so the missing project was filtered out before that step.
Why only this test
The change only adds the property in the -restore switch / ExecuteRestore path (implicit restore). The other multi-TFM tests run an explicit dotnet restore step, which does not go through ExecuteRestore, so they never get the property and still pass. The --framework pin is not required to trigger it — ExcludeRestorePackageImports=true + a multi-TFM project + a missing ProjectReference is sufficient.
Recommendation
Revert dotnet/msbuild#14274 (or hold it behind an off-by-default gate) until the underlying NuGet restore-target behavior — _GenerateRestoreGraphProjectEntry not honoring SkipNonexistentProjects — is addressed. Reverting the MSBuild change restores the previous (graceful-skip) behavior.
Regressed by MSBuild #14274 (ExcludeRestorePackageImports during implicit restore), which fails with MSB3202 on multi-TFM projects that have a nonexistent <ProjectReference>. The MSBuild change is being reverted in dotnet/msbuild#14349. Re-enable tracked by #55263. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 395f543d-fb00-4a06-95b1-a7738432a141
Member
|
Pushed a commit to this codeflow branch temporarily disabling
|
ViktorHofer
approved these changes
Jul 14, 2026
JanProvaznik
approved these changes
Jul 14, 2026
ViktorHofer
added a commit
to dotnet/msbuild
that referenced
this pull request
Jul 14, 2026
…14349) Reverts the change from #14274, which injected `ExcludeRestorePackageImports=true` into the implicit restore global properties (behind change wave 18.10) so that NuGet's restore re-invocation would reuse MSBuild's initial evaluation instead of forcing a second one. ### Why revert The change breaks restore for projects that have a **nonexistent `<ProjectReference>`**. Once the top-level restore evaluation shares the same global property set that NuGet's inner `_GenerateRestoreProjectPathWalk` invocation uses, that walk runs in the *same* project instance and its unfiltered `_RestoreProjectPathItems` (which contains the raw `ProjectReference` paths, including missing ones) leaks into `_GenerateRestoreGraph`'s `_GenerateRestoreGraphProjectEntry` MSBuild call. That call does not set `SkipNonexistentProjects`, so it fails with `MSB3202` instead of skipping the missing project. ``` NuGet.targets(571,5): error MSB3202: The project file "...\TestLibrary\TestLibrary.csproj" was not found. ``` This regressed the dotnet/sdk test `ItCanTestAMultiTFMProjectWithImplicitRestore` — see dotnet/sdk#55245 for the full root-cause analysis and repro. ### Details - Only the implicit-restore (`-restore` switch / `ExecuteRestore`) path was affected; explicit `dotnet restore` / `-t:Restore` never added the property. - Reproduced with `dotnet build -t:Restore /p:ExcludeRestorePackageImports=true` on a multi-TFM project with a dangling `ProjectReference`: without the property restore succeeds (missing project skipped gracefully); with it, `MSB3202`. ### What this PR does - Removes the `ExcludeRestorePackageImports=true` injection in `XMake.ExecuteRestore`, replacing it with a comment documenting **why** the property must not be set there. - Removes the `ExcludeRestorePackageImports` / `ExcludeRestorePackageImportsValue` constants and the two related unit tests. - Removes the 18.10 ChangeWaves.md bullet for this feature. - **Retains** change wave `18.10` itself — it is still used by the `-getProperty`/`-getItem` evaluation change (#14290). --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…_restored Same root cause as ItCanTestAMultiTFMProjectWithImplicitRestore (#55263): dotnet/msbuild#14274 (ExcludeRestorePackageImports during restore, change wave 18.10) regresses restore for projects excluded from restore via _IsProjectRestoreSupported. For the 'TestApp.' case, TestApp.deps.json lists transitive non-SDK project references by their project name instead of the overridden AssemblyName. Disable pending the msbuild#14349 revert flowing in. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 499249b7-514f-4ecf-88bc-2466455069c5
ViktorHofer
approved these changes
Jul 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
This is a codeflow update. It may contain both source code changes from
the VMR
as well as dependency updates. Learn more here.
This pull request brings the following source code changes
From https://github.com/dotnet/dotnet
Updated Dependencies
Associated changes in source repos
Diff the source with this PR branch