feat(desktop): add Windows Toast notifications via go-toast library (#5294)#5365
Closed
Barsit wants to merge 1 commit into
Closed
feat(desktop): add Windows Toast notifications via go-toast library (#5294)#5365Barsit wants to merge 1 commit into
Barsit wants to merge 1 commit into
Conversation
Implements esengine#5294 - adds Windows system toast notifications for the Wails desktop app when the app is in the background (minimized to tray). Changes: - internal/notify/sender_windows.go: replace PowerShell BurntToast calls with go-toast library for reliable Windows Toast API integration - desktop/app.go: add notificationSender field, initialize in startup() when NotificationsConfig.Enabled is true - desktop/tabs.go: wrap tabEventSink with notify.Sink in buildTabControllerWithLoadedSession() so TurnDone/ApprovalRequest/ AskRequest events trigger OS toast notifications Front-end sounds (playSuccessChime / playAttentionChime) were already wired and remain unchanged. Co-Authored-By: Claude <noreply@anthropic.com>
Contributor
Author
|
@codex review |
|
To use Codex here, create a Codex account and connect to github. |
SivanCola
added a commit
to SivanCola/DeepSeek-Reasonix
that referenced
this pull request
Jul 3, 2026
Credits the Windows Toast direction from PR esengine#5365 in the repository history. Co-authored-by: Barsit <86559454+Barsit@users.noreply.github.com>
Collaborator
|
感谢 @Barsit 的实现和验证。#5847 已经合并到 main-v2,并吸收/改良了这个 PR 的核心贡献:
#5847 还补上了 per-workspace config loading、macOS/Linux 共享平台 sender 复用、focused desktop regression tests,并修正了 Windows fallback 可能重复通知的问题。 贡献归因已经放进 #5847 的 PR body;采用自 #5365 的贡献也通过 commit-level 因为 #5847 已覆盖并关闭 #5294,这个 PR 现在作为 superseded/adopted 关闭,而不是拒绝该方向。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
背景
Issue #5294: 桌面端(Wails)运行在后台时,任务完成或需要审批时没有 Windows 系统通知。
改动
3 个文件,45 行新增,15 行删除:
触发事件
配置
编辑 ~/.config/reasonix.toml:
测试
前台

后台

Closes #5294