Skip to content

Add desktop system notifications for turns / 为桌面端任务完成增加系统通知#5847

Merged
SivanCola merged 4 commits into
esengine:main-v2from
SivanCola:feature/desktop-system-notifications
Jul 3, 2026
Merged

Add desktop system notifications for turns / 为桌面端任务完成增加系统通知#5847
SivanCola merged 4 commits into
esengine:main-v2from
SivanCola:feature/desktop-system-notifications

Conversation

@SivanCola

@SivanCola SivanCola commented Jul 3, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Route desktop controller events through the existing notification sink when [notifications].enabled is set.
  • Send system notifications for completed turns, failed turns, approval requests, and ask requests without changing the UI event stream.
  • Use the existing macOS/Linux platform senders and upgrade Windows delivery to native Toast notifications through go-toast, relying on its built-in PowerShell fallback.

Related

Repository contributor credits

Cache impact

None. This only wraps local desktop event sinks and platform notification delivery; it does not change provider prompts, tool schemas, serialization, MCP registration, or model-visible context.

Test plan

  • go test ./internal/config ./internal/notify
  • GOOS=linux GOARCH=amd64 go test -c ./internal/notify -o /tmp/reasonix-notify-linux.test
  • GOOS=windows GOARCH=amd64 go test -c ./internal/notify -o /tmp/reasonix-notify-windows.test.exe
  • cd desktop && go test .
  • go test ./...

@SivanCola SivanCola requested a review from esengine as a code owner July 3, 2026 06:58
@github-actions github-actions Bot added v2 Go rewrite (1.x) — main-v2 branch, active development desktop Wails desktop app (desktop/**) config Configuration & setup (internal/config) labels Jul 3, 2026
SivanCola and others added 3 commits July 3, 2026 14:59
Credits the Windows Toast direction from PR esengine#5365 in the repository history.

Co-authored-by: Barsit <86559454+Barsit@users.noreply.github.com>
@SivanCola SivanCola merged commit a9928d3 into esengine:main-v2 Jul 3, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

config Configuration & setup (internal/config) desktop Wails desktop app (desktop/**) v2 Go rewrite (1.x) — main-v2 branch, active development

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature]: 希望桌面端加入通知功能,在跑完的时候通过windows系统发通知

1 participant