ENG-177: Migrate rich toasts to useNotification#7702
Merged
gilluminate merged 5 commits intomainfrom Mar 20, 2026
Merged
Conversation
…useMessage Replace Chakra useToast with Ant Design useNotification for toasts with action links (View, navigate) and useMessage for simple success/error feedback. Delete unused SuccessToastContent helper. Fix deprecated `btn` prop to `actions` across all notification calls. Inline useAPIHelper logic for conflict-resolved files. Add shouldShowNotification Cypress helper. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
Greptile SummaryThis PR is the third installment of the ENG-177 toast migration series, replacing Chakra UI's Key changes:
Confidence Score: 5/5
Important Files Changed
Last reviewed commit: "Use Space component ..." |
...min-ui/src/features/datastore-connections/system_portal_config/forms/ConnectorParameters.tsx
Outdated
Show resolved
Hide resolved
clients/admin-ui/src/features/system/hooks/useSystemFormTabs.tsx
Outdated
Show resolved
Hide resolved
…files Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
12 tasks
3cc4525 to
7bcc595
Compare
Tests were looking for [data-testid='toast-success-msg'] which was rendered by the old Chakra toast wrapper. Action center tests now use shouldShowNotification for toasts with action links and shouldShowMessage for simple success feedback. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket ENG-177
Description Of Changes
Migrates all "rich" toast calls (those with action links like View, Navigate) from Chakra
useToastto Ant DesignuseNotification, and simple success/error feedback touseMessage. This is 3 of 4 in the ENG-177 toast migration series.Code Changes
useDSRErrorAlertto useuseNotificationwith persistentduration: 0and key-based cleanupRegulationManagementandLocationManagementsuccess toasts with "View" action links touseNotificationuseSystemFormTabssuccess toast with "View data map" / "Add privacy declarations" actions touseNotificationuseDiscoveredSystemAggregateTable,useDiscoveredAssetsTable,DiscoveredAssetActionsCell,DiscoveredSystemAggregateActionsCell) touseNotificationfor action-link toasts anduseMessagefor simple toastsSuccessToastContent.tsxhelperbtn->actionsprop across all notification calls (including pre-existingAssessmentTaskStatusIndicator)useAPIHelperfor 3 conflict-resolved files (ConnectorParameters,DSRCustomizationModal,ManualProcessingList)shouldShowNotificationCypress helper toant-support.tsSteps to Confirm
btndeprecation warningsPre-Merge Checklist
CHANGELOG.mdupdated🤖 Generated with Claude Code