This PR is to add comments to processUpdatingUFS in pkg/ddc/alluxio/ufs_internal.go.#6082
This PR is to add comments to processUpdatingUFS in pkg/ddc/alluxio/ufs_internal.go.#6082haooo0418 wants to merge 1 commit into
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @haooo0418. Thanks for your PR. I'm waiting for a fluid-cloudnative member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds a descriptive comment block to the processUpdatingUFS function in pkg/ddc/alluxio/ufs_internal.go explaining its purpose and steps. There are no review comments, and I have no feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
|
|
@haooo0418 — this PR is blocked from merging by a failing DCO check. Please resolve this now. For a single-commit PR: For multiple commits on this branch: The code review side is finished and any merge labels already on the PR will take effect once DCO turns green. Reference: https://github.com/apps/dco |
| // processUpdatingUFS updates the under file system (UFS) mount configuration for the Alluxio engine. | ||
| // It first determines the update method based on whether mount config map is enabled, | ||
| // then if the update succeeds, it resets the dataset's UfsTotal status to trigger a metadata sync, | ||
| // and finally updates the mount timestamp when new mount paths are added. |
There was a problem hiding this comment.
Small wording nit on this new doc comment: it jumps from "resets the dataset's UfsTotal status to trigger a metadata sync" straight to updating the mount timestamp, but the function actually invokes SyncMetadata explicitly after the status reset, and only then calls updateMountTime (and only when ufsToUpdate.ToAdd() is non-empty). Could you tweak the last sentence to call out SyncMetadata so the doc stays aligned with the control flow? For example: "...resets the dataset's UfsTotal status to Calculating, invokes SyncMetadata, and finally updates the mount timestamp when new mount paths have been added."
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6082 +/- ##
==========================================
+ Coverage 61.22% 64.77% +3.54%
==========================================
Files 444 484 +40
Lines 30557 33892 +3335
==========================================
+ Hits 18710 21954 +3244
+ Misses 10307 10215 -92
- Partials 1540 1723 +183 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
2 participants
Ⅰ. Describe what this PR does
This PR adds function-level comments to processUpdatingUFS in pkg/ddc/alluxio/ufs_internal.go.
Ⅱ. Does this pull request fix one issue?
fixes #6081
Ⅲ. Special notes for reviews
None