Skip to content

This PR is to add comments to processUpdatingUFS in pkg/ddc/alluxio/ufs_internal.go. #6082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
haooo0418 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

This PR is to add comments to processUpdatingUFS in pkg/ddc/alluxio/ufs_internal.go. #6082

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions pkg/ddc/alluxio/ufs_internal.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,6 +145,10 @@ func (e *AlluxioEngine) FindUnmountedUFS() (unmountedPaths []string, err error)
return fileUtils.FindUnmountedAlluxioPaths(alluxioPaths)
}

// processUpdatingUFS updates the under file system (UFS) mount configuration for the Alluxio engine.
// It first determines the update method based on whether mount config map is enabled,
// then if the update succeeds, it resets the dataset's UfsTotal status to trigger a metadata sync,
// and finally updates the mount timestamp when new mount paths are added.

@cheyang cheyang Jun 30, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small wording nit on this new doc comment: it jumps from "resets the dataset's UfsTotal status to trigger a metadata sync" straight to updating the mount timestamp, but the function actually invokes SyncMetadata explicitly after the status reset, and only then calls updateMountTime (and only when ufsToUpdate.ToAdd() is non-empty). Could you tweak the last sentence to call out SyncMetadata so the doc stays aligned with the control flow? For example: "...resets the dataset's UfsTotal status to Calculating, invokes SyncMetadata, and finally updates the mount timestamp when new mount paths have been added."

func (e *AlluxioEngine) processUpdatingUFS(ufsToUpdate *utils.UFSToUpdate) (updateReady bool, err error) {
dataset, err := utils.GetDataset(e.Client, e.name, e.namespace)
if err != nil {
Expand Down
Loading