docs(skill): 428 -- an empty conclusion is not a verdict - #2995
Merged
Conversation
Three status readers of mine were wrong in one session, each toward a verdict
the tool had not given:
* `grep -c '^ERROR'` over yosys output -> 0 for six files that all exit 1
(yosys writes `<path>:<line>: ERROR:`, so nothing starts with the anchor)
* `cmd | head -12; echo rc=$?` -> rc=0 for a run that exits 1 (that is head's
status; already section 245, met again through my own pipe)
* `conclusion not in ('success','skipped',None)` -> printed FAIL for an
in-progress run, whose conclusion is `''` and not null
The third is the general case. `status` says whether it finished; `conclusion`
says what it decided; conclusion is empty until status is completed. Collapsing
them makes an unfinished run read as a verdict, and which verdict depends on how
the filter is spelled.
Same shape as the `none == none` finding on that page, one layer up: a sentinel
meaning "no answer", compared as though it were an answer. In all three the
wrong reading was the reassuring one.
Refs #2987
Contributor
|
📓 NotebookLM Notebook linked to this PR
This notebook contains session context, decisions, and artifacts for this work. |
Contributor
PR DashboardGenerated at: 2026-08-30 22:13:23 UTC
Summary
Seal Status
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One section, earned by hitting the same class three times in one session — and
each time the wrong reading was toward a verdict the tool had not given.
yosys -p "read_verilog $f" | grep -c '^ERROR'0for six files<path>:<line>: ERROR: …, so nothing starts with the anchort27c icarus-simulate spec | head -12; echo rc=$?rc=0$?is head's status — already section 245, met again through a pipe I wrote myselfconclusion not in ('success','skipped',None)FAIL: FPGA E2E Build'', not null, and master was cleanThe third is the general case the other two are instances of. GitHub gives two
fields because they answer two questions:
statussays whether it finished,conclusionsays what it decided, andconclusionis empty untilstatusiscompleted. Collapsing them makes an unfinished run read as a verdict, andwhich verdict depends on how the filter happens to be spelled — which is not a
property of the world.
Same shape as the
none == nonefinding already on that page, one layer up: asentinel meaning no answer, compared as though it were an answer. There the
record lied; here the reader did.
tri skill check: 392 sections, no number used twice.Refs #2987
🤖 Generated with Claude Code