Repository navigation
IBX-11939: Added a shared SchemaBuilderEvent subscriber for plain ORM entities - #852
Merged
Merged
Conversation
…positoryInstaller The suite still pointed at tests/bundle/Installer, which hasn't existed since the IBX-538 rename, so none of the RepositoryInstaller bundle tests ran. Same path the 5.0 branch already uses.
IBX-538 renamed CoreInstaller's installer type from "clean" to "ibexa-oss", but the moved test kept asserting the old one. It went unnoticed because the suite never ran these tests.
… entities OrmEntitiesSchemaSubscriber contributes the tables (and sequences) of a given list of Doctrine ORM entities to the SchemaBuilderEvent schema, derived from their mappings via SchemaTool. ibexa/taxonomy and ibexa/connector-payum each carried an identical copy of this logic, differing only in the entity list. Each package now registers its own instance of this class instead, listing just its own entities.
This was referenced Sep 28, 2026
ibexa-workflow-automation-1
Bot
requested review from
ViniTou,
alongosz,
barw4,
bnowak,
ciastektk,
konradoboza,
mikadamczyk,
tbialcz and
wiewiurdp
and removed request for
a team
September 28, 2026 17:48
|
konradoboza
approved these changes
Sep 28, 2026
bnowak
approved these changes
Sep 29, 2026
tbialcz
approved these changes
Sep 29, 2026
5 of 6 tasks
Steveb-p
added a commit
that referenced
this pull request
Sep 29, 2026
…line-sql' into base/ibx-11939-4.6-merged-5.0 #785 was rebased onto 4.6 after #852 landed there. Its tree is identical to the pre-rebase head f75405c this base already contains, so this merge only records the rebased history and keeps the base's own tree (-s ours). A regular merge would have gone back to the old merge base and re-applied the lines of #785 that earlier merges here resolved the 5.0 way.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Related PRs:
Description:
Extracted from #785 so it can be reviewed and merged on its own. #785 keeps the same code for now, so it stays testable as it is; once this lands, its diff shrinks by this much on the next sync with
4.6.OrmEntitiesSchemaSubscribercontributes the tables (and sequences) of a given list of plain Doctrine ORM entities to theSchemaBuilderEventschema, generated from their mappings viaSchemaTool. ibexa/taxonomy#431 and ibexa/connector-payum#39 each carried an identical copy of this logic; each now just registers its own instance, listing its own entities:Only the listed entities' own tables are copied over.
SchemaTool::getSchemaFromMetadata()firespostGenerateSchemaon the entity manager's shared event manager, so any other listener there (Messenger's Doctrine transport auto-setup, for one) adds its own table to the ORM schema too - those are skipped, as are tables the target schema already has.Two small test fixes come along, because without them the new test wouldn't run in CI at all. The
bundle_installersuite inphpunit.xmlstill pointed attests/bundle/Installer, gone since IBX-538, so none of the RepositoryInstaller bundle tests ran. Running them again surfacedIbexaInstallerExtensionTeststill asserting the pre-IBX-538cleaninstaller type.5.0already has both.