Repository navigation
IBX-11939: Added a shared SchemaBuilderEvent subscriber for plain ORM entities - #853
Closed
Steveb-p wants to merge 2 commits into
Conversation
Uses 5.0's readonly class / promoted constructor style, passes array_values() of the foreign key columns (DBAL 4 requires a list), and the test uses APIs present in both DBAL 3 and 4 (getCreateTablesSQL(), connection-provided SQLite platform) with XSD validation enabled, so it carries over to 6.0 unchanged.
This was referenced Sep 28, 2026
|
ibexa-workflow-automation-1
Bot
requested review from
ViniTou,
alongosz,
barw4,
bnowak,
ciastektk,
konradoboza,
mikadamczyk,
tbialcz and
wiewiurdp
and removed request for
a team
September 28, 2026 17:50
konradoboza
approved these changes
Sep 28, 2026
bnowak
approved these changes
Sep 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related PRs:
Description:
5.0 counterpart of #852, see there for what
OrmEntitiesSchemaSubscriberdoes. Targetsbase/ibx-11939-orm-entities-schema-subscriber-4.6-merged-5.0(5.0with #852 merged in), so the diff only shows what changes for 5.0:final readonlyclass with promoted constructor properties, and arrow functions instead of closures.array_values()around the foreign key column lists, since DBAL 4 requires a list.getCreateTablesSQL(), the SQLite platform taken from a real connection) and enables mapping XSD validation, so it carries over to 6.0 with PHPUnit 11 changes only.