IBX-11939: Added the missing ON UPDATE action to the SQLite foreign key - #155
Merged
Steveb-p merged 1 commit intoOct 5, 2026
Merged
Conversation
…keys The SQLite install schema was generated with DBAL's own SqlitePlatform, which reports no foreign key support and so leaves every ON UPDATE action out. The SchemaBuilderEvent path uses doctrine-schema's SqliteDbPlatform, which keeps them, so on SQLite the two install paths created different foreign keys. This adds the action each foreign key declares in schema.yaml.
|
Steveb-p
added this pull request to stack #159
October 5, 2026 11:09
Steveb-p
marked this pull request as ready for review
October 5, 2026 11:09
This was referenced Oct 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Stacked on #128: it targets #128's branch and lands right after it.
Related PRs:
Description:
Its foreign key declares
ON UPDATE CASCADEinschema.yaml, and the MySQL and PostgreSQL install schemas have it, but the SQLite one left it out. The file was generated with DBAL's ownSqlitePlatform, which reports no foreign key support and so dropsON UPDATE. TheSchemaBuilderEventpath goes through doctrine-schema'sSqliteDbPlatform, which keeps it, so on SQLite the two install paths created different foreign keys.This adds the declared action to each foreign key, and nothing else. Built from this file and from
schema.yamlthroughSqliteDbPlatform, the two SQLite databases now come out the same under ibexa/test-core#68's comparison.#128 isn't released yet, so this fixes the baseline itself rather than adding a migration.