[monitoring] Add OpenTelemetry spans in scd/operational_intents_handler #1366
Closed
the-glu wants to merge 2 commits intointeruss:masterfrom
Closed
[monitoring] Add OpenTelemetry spans in scd/operational_intents_handler #1366the-glu wants to merge 2 commits intointeruss:masterfrom
the-glu wants to merge 2 commits intointeruss:masterfrom
Conversation
This was referenced Jan 29, 2026
Contributor
Author
|
Following discussions I close that one (that has been partially overwritten by #1391 ). I do think we want as much inside as possible, but since there is no easy way without having it everywhere, that probably not the correct approach; and if needed we could still add specific span in the future. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a set of 3 PRs, proposition to add OpenTelemetry to generate optional traces.
You can check the base PR, the one for handlers and the one for datastores.
This PR add as an example spans in
pkg/scd/operational_intents_handler.goSpans look like that:
Idea would be to have that in all handlers.